RSDK-2545 Allow fail-through for mDNS #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaniels
approved these changes
Apr 28, 2023
viambot
added
safe to test
Otterverse
changed the title
Otterverse
commented
Apr 28, 2023
| logger, | ||
| ) | ||
| if err != nil { | ||
| return nil, err | ||
| logger.Warnw(mDNSerr, "error", err) | ||
| sOpts.disableMDNS = true |
There was a problem hiding this comment.
Technically not needed, but code is complex enough that IF any other logic were added to look at this value later, it'd be good to have it reflect the actual situation IMHO.
| if (ifc.Flags&net.FlagUp) == 0 || | ||
| (ifc.Flags&net.FlagLoopback) == 0 || | ||
| (ifc.Flags&net.FlagMulticast) == 0 { | ||
| if (ifc.Flags&net.FlagUp) == 0 || (ifc.Flags&net.FlagLoopback) == 0 { |
There was a problem hiding this comment.
So by default linux doesn't have the "multicast" flag set on the loopback interface, so I removed that check. It appears that you can join a group on an interface without that being set explicitly, and all tests still pass.
edaniels
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers a case where the loopback adapter doesn't support multicast, such as in some docker containers (usually cross-architecture emulation.)