Added vial support for For_Science #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xyzz
requested changes
Aug 26, 2024
keyboards/for_science/keyboard.json
Outdated
| @@ -14,8 +14,8 @@ | |||
| }, | |||
| "features": { | |||
| "bootmagic": true, | |||
| "command": true, | |||
There was a problem hiding this comment.
do not modify files outside of the vial keymap that also exist in upstream qmk, this will cause conflicts during merge
Moved QMK feature disables to vial/rules.mk to maintain compatibility with upstream QMK.
|
there are still modifications outside of the vial keymap |
|
I'm sorry for the frankly egregious series of errors I've made. It should hopefully be correct now. |
WoofWoofGrr
pushed a commit
to WoofWoofGrr/vial-qmk
that referenced
this pull request
Oct 28, 2024
* Added vial support for For_Science * Update rules.mk * Disabled QMK features to keep firmware size in check for AVR * moved qmk feature flags from keyboard.json to vial/rules.mk Moved QMK feature disables to vial/rules.mk to maintain compatibility with upstream QMK. * Delete rules.mk
paladin235
pushed a commit
to paladin235/vial-qmk
that referenced
this pull request
Jan 11, 2025
* Added vial support for For_Science * Update rules.mk * Disabled QMK features to keep firmware size in check for AVR * moved qmk feature flags from keyboard.json to vial/rules.mk Moved QMK feature disables to vial/rules.mk to maintain compatibility with upstream QMK. * Delete rules.mk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.