Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHPY-10 documentation #8

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

lennertvandevelde
Copy link
Contributor

@lennertvandevelde lennertvandevelde commented Apr 5, 2023

Documentation generated with https://vemel.github.io/handsdown/.

Copy link
Member

@maartends maartends left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is - or will be - a public library, I would definitely include the README as it was before as well: the "Usage" and "Synopsis" sections provide a useful introduction to the library.

The title of the README should best remain "MediaHaven Python Library"

Copy link
Member

@maartends maartends left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

README.md Outdated Show resolved Hide resolved
Co-authored-by: Maarten <763374+maartends@users.noreply.github.com>
Copy link
Contributor

@spacid spacid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which version of handsdown was used to generate the docs?

It might be advised to:

  • Add the handsdown library in the requirements-dev.txt file.
  • Add some information about how to generate the docs in the README.

@@ -0,0 +1,6 @@
#!/bin/bash

handsdown
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
handsdown
handsdown mediahaven

Only create docs for the files in the mediahaven folder. Without it, it also tried to generate docs for certain packages in my venv folder.

#!/bin/bash

handsdown
mv docs/README.md .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This moves a generated README.md file to the root folder, essentially overwriting the existing README file. This is not desired.

Comment on lines +5 to +6
sed -i 's/mediahaven\//docs\/mediahaven\//g' README.md
find docs/ -type f -exec sed -i 's/\.\.\/README\.md/..\/..\/README.md/g' {} \;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not moving the README file makes these replace actions unnecessary I assume?

@spacid
Copy link
Contributor

spacid commented Jun 28, 2023

Note: the docs needs to be remade because of merge of https://github.com/viaacode/mediahaven-python/pull/10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants