Fix braceless if differentiation in reverse mode #1058
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1058 +/- ##
=======================================
Coverage 94.34% 94.34%
=======================================
Files 55 55
Lines 8307 8311 +4
=======================================
+ Hits 7837 7841 +4
Misses 470 470
|
|
Can you add a test to make codecov happy? |
Yes, I wanted to ask you about that. Should I include the generated code in the tests? Now it only checks if the values are right. |
For this particular change you can add the test in |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
ovdiiuv
force-pushed
the
tbrif
branch
2 times, most recently
from
df060ff to
bce9443
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
As in vgvassilev#1049, the statement inside the braceless if is not included causing an error. Fixes:vgvassilev#1049
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
As in #1049, the statement inside the braceless if isn't included, causing an error. To avoid that now we check if
thenDiff.getStmt_dx()is empty, if so we create if statement with!(orig_cond)condition to ensure correct handling ofelse ifconditions.Fixes: #1049