-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long Read Giraffe #4323
Open
adamnovak
wants to merge
1,207
commits into
master
Choose a base branch
from
lr-giraffe
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Long Read Giraffe #4323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make -c be --correctly-mapped and -e be --exact-name like in the main branch.
…e funnel properly
… use too much memory
…going to use too much memory" This reverts commit 2b9ac09.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg giraffe
now has--parameter-preset hifi
and--parameter_preset r10
for using a new chaining-based algorithm to map long reads.--parameter-preset sr
uses the new algorithm for single-ended short reads; the old--parameter-preset default
and--parameter-preset fast
remain available with the old non-chaining algorithm.giraffe-facts.py
script now knows how to read GAM files internally and no longer needs JSON preprocessing.Description
This adds the much-anticipated Long Read Giraffe to mainline vg.