-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unmount improvements #507
Unmount improvements #507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Commit message is missing
- Where is the typo?
- Code after execl makes no sense
Otherwise ok
encfs/FileUtils.cpp
Outdated
wait(&status); | ||
if ((pid = fork()) == 0) { | ||
execl("/usr/bin/pkill", "/usr/bin/pkill", "-INT", "-f", string("(^|/)encfs .*/.* ").append(mountPoint).append("?( |$)").c_str(), (char *)0); | ||
_Exit(127); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code after execl is never reached!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep but this is to make the child to exit if execl
fails 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. But shouldn't we print an error message in that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, improved with log messages !
I've just improved commit message. |
Log OSX unmount system error Better handle Cygwin unmount child Use WinFsp expected INT signal
Hi,
I would have liked to keep some things from #503, so, this PR :
INT
signal expected by WinFsp rather than defaultTERM
.Thank you !
Ben