Correct unused-parameter warnings #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfjakob
reviewed
Oct 29, 2017
CMakeLists.txt
Outdated
| @@ -180,7 +180,6 @@ if (${CMAKE_MAJOR_VERSION}.${CMAKE_MINOR_VERSION} GREATER 3.5) # Need 3.6 or abo | |||
| ",-google-runtime-int" | |||
| ",-google-runtime-references" | |||
| ",-misc-misplaced-widening-cast" | |||
| ",-misc-unused-parameters" | |||
There was a problem hiding this comment.
All checks are enabled, but the listed ones, so I simply re-enable misc-unused-parameters 👍
There was a problem hiding this comment.
OK for you @rfjakob ? Thx 👍
encfs/main.cpp
Outdated
| @@ -621,7 +619,7 @@ int main(int argc, char *argv[]) { | |||
| // encfs_oper.releasedir = encfs_releasedir; | |||
| // encfs_oper.fsyncdir = encfs_fsyncdir; | |||
| encfs_oper.init = encfs_init; | |||
| encfs_oper.destroy = encfs_destroy; | |||
| // encfs_oper.destroy = encfs_destroy; | |||
There was a problem hiding this comment.
Unsure about this. Leaving encfs_oper.destroy = NULL does not change the behavoir ob libfuse?
In any case, should be deleted instead of commented out.
There was a problem hiding this comment.
I verified this, and no, the function is simply called if it exists, but is not replaced by anything else : https://github.com/libfuse/libfuse/blob/fuse_2_9_5/lib/fuse.c#L2614
I just removed the comment.
Thx 👍
rfjakob
approved these changes
Nov 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR helps with #427 and #426, it solves warnings regarding unused-parameter.
Thank you 👍
Ben