Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markpadbe branch #8

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Markpadbe branch #8

wants to merge 7 commits into from

Conversation

markpadbe
Copy link
Collaborator

  • Update init console message

Resolves: MWPW-NUMBER

Test URLs:

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Feb 6, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@markpadbe markpadbe marked this pull request as draft February 6, 2024 22:37
@markpadbe markpadbe marked this pull request as ready for review February 6, 2024 22:54
@markpadbe markpadbe marked this pull request as draft February 6, 2024 22:54
akobrina
akobrina requested changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@akobrina akobrina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting change to console log message.

libs/blocks/marquee/marquee.js Outdated
console.log('blah blah');
}

if (el.classList.contains('new-variant')) console.log('got it...in the new branch!');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akobrina, Thank you. I've updated the code.

@ivanvatadobe
Copy link
Collaborator

this looks good to me

@markpadbe markpadbe requested a review from akobrina February 6, 2024 23:09
akobrina
akobrina approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@akobrina akobrina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! Thanks.

@markpadbe markpadbe marked this pull request as ready for review February 6, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akobrina akobrina akobrina approved these changes

@jstanleyAdobe jstanleyAdobe Awaiting requested review from jstanleyAdobe

@ivanvatadobe ivanvatadobe Awaiting requested review from ivanvatadobe

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markpadbe @ivanvatadobe @akobrina @ai-adobe