Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cancellation in ReadLine/ReadLineAsync methods (.NET 7) #49

Closed
1 task done
alexrp opened this issue Dec 16, 2021 · 4 comments
Closed
1 task done

Support cancellation in ReadLine/ReadLineAsync methods (.NET 7) #49

alexrp opened this issue Dec 16, 2021 · 4 comments
Labels
area: io Issues related to core terminal I/O. type: feature Issues that are classified as feature requests.
Milestone
v1.0

Comments

@alexrp
Copy link
Sponsor Member

alexrp commented Dec 16, 2021 •
edited
Loading

Depends on:

Blocked on: dotnet/runtime#20824
@alexrp alexrp added type: feature Issues that are classified as feature requests. state: blocked Issues that are blocked on some other issue/work. area: io Issues related to core terminal I/O. labels Dec 16, 2021
@alexrp alexrp self-assigned this Dec 16, 2021
This was referenced Dec 16, 2021
Closed
Closed
@alexrp alexrp changed the title Support a CancellationToken parameter in ReadLine methods Support a CancellationToken parameter in ReadLine/ReadLineAsync methods Dec 17, 2021
@alexrp alexrp changed the title Support a CancellationToken parameter in ReadLine/ReadLineAsync methods Properly support cancellation in ReadLine/ReadLineAsync methods Dec 20, 2021
@alexrp alexrp added this to the v2.0 milestone Dec 20, 2021
@alexrp alexrp changed the title Properly support cancellation in ReadLine/ReadLineAsync methods Properly support cancellation in ReadLine/ReadLineAsync methods (.NET 7) Dec 23, 2021
@alexrp alexrp changed the title Properly support cancellation in ReadLine/ReadLineAsync methods (.NET 7) Support cancellation in ReadLine/ReadLineAsync methods (.NET 7) Dec 23, 2021
@alexrp
Copy link
Sponsor Member Author

alexrp commented Jan 1, 2022

https://github.com/alexrp/system-terminal/blob/acc9de6d5a63025bb9278b4817c9e265513b3089/src/core/IO/TerminalReader.cs#L81-L95

@alexrp
Copy link
Sponsor Member Author

alexrp commented Jan 18, 2022

(It seems like only ReadLineAsync will get a CancellationToken overload.)

@alexrp alexrp modified the milestones: v2.0, v1.0 Jul 13, 2022
@alexrp alexrp added state: deliberation Issues that require considerable deliberation and/or discussion before a resolution can be found. and removed state: blocked Issues that are blocked on some other issue/work. labels Oct 22, 2022
@alexrp
Copy link
Sponsor Member Author

alexrp commented Oct 22, 2022

Need to determine what to do about ReadLine...

alexrp added a commit that referenced this issue Oct 22, 2022
@alexrp
Forward cancellation token in TerminalReader.ReadLineAsync().
ef543fd 
Part of #49.
@alexrp
Copy link
Sponsor Member Author

alexrp commented Oct 24, 2022

It might make the most sense to just not support cancellation in synchronous methods. That seems to be the norm throughout the BCL.

@alexrp alexrp closed this as completed in bd889b9 Oct 29, 2022
@alexrp alexrp removed the state: deliberation Issues that require considerable deliberation and/or discussion before a resolution can be found. label Oct 29, 2022
@alexrp alexrp removed their assignment Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: io Issues related to core terminal I/O. type: feature Issues that are classified as feature requests.
Milestone
v1.0
Development

No branches or pull requests
1 participant
@alexrp