Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChildProcess.Kill() can let internal exceptions through #139

Closed
alexrp opened this issue Jan 7, 2024 · 0 comments
Closed

ChildProcess.Kill() can let internal exceptions through #139

alexrp opened this issue Jan 7, 2024 · 0 comments
Labels
area: processes Issues related to spawning child processes. type: bug Issues that are classified as bug reports.
Milestone

Comments

@alexrp
Copy link
Sponsor Member

alexrp commented Jan 7, 2024

try
{
// TODO: Review exceptions that can be thrown here.
_process.Kill(entireProcessTree);
}
catch (InvalidOperationException)
{
// The process is already gone.
}

https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.process.kill#system-diagnostics-process-kill(system-boolean)

I suspect the documentation here may not match the current Process implementation...

@alexrp alexrp added type: bug Issues that are classified as bug reports. state: confirmed Bugs that have been confirmed. area: processes Issues related to spawning child processes. labels Jan 7, 2024
@alexrp alexrp added this to the v1.0 milestone Jan 7, 2024
@alexrp alexrp self-assigned this Jan 7, 2024
alexrp added a commit that referenced this issue Jan 8, 2024
@alexrp alexrp removed the state: confirmed Bugs that have been confirmed. label Jan 8, 2024
@alexrp alexrp closed this as completed in f4845b7 Jan 8, 2024
@alexrp alexrp removed their assignment Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: processes Issues related to spawning child processes. type: bug Issues that are classified as bug reports.
Development

No branches or pull requests

1 participant