[VEUE-864] Share Second Camera #563
Conversation
|
Task linked: VEUE-864 Share Second Camera |
|
Your Render PR Server URL is https://stage-pr-563.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-c30uqfs64ckh7frfg3tg. |
Sirbuland
force-pushed
the
VEUE-864
branch
3 times, most recently
from
4b35ea0 to
619e75c
Compare
| private boundUseStartOffset: EventListener; | ||
|
|
||
| element!: HTMLElement; |
There was a problem hiding this comment.
what's the declare for?
There was a problem hiding this comment.
@hcatlin so I faced this error
TypeError: Cannot set property which has only a getter for our targets in controllers
This was the issue if you set useDefineForClassFields to true in tsconfig file. But this flag was causing a lot of external libs to fail too! So I removed this flag and MobX worked without it (it was recommended on their official installation guide). Install Guide.
But for typescript it will be making it mandatory to not use class level declarations if an accessor/getter is already defined in base class. Also this is becoming default for ESNext. Further details are in this issue: microsoft/TypeScript#27644
Btw here my declare is not doing much but I leave it (even after removing flag) there just because of my above understanding and search. Please let me know if we should keep it or remove it for now.
There was a problem hiding this comment.
@hcatlin also I read this blog for solution https://dieterlunn.ca/stimulus-and-typescript/
There was a problem hiding this comment.
You can keep it, I was more just curious!
PR Functionality
This PR adds the ability to share another camera at the current place of screen share in BBB. It provides with an option to select available cameras and use any one at the place of current primary area.