Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pokemon custom data! #161

Closed
4 tasks done
vestrel00 opened this issue Jan 2, 2022 · 3 comments
Closed
4 tasks done

Pokemon custom data! #161

vestrel00 opened this issue Jan 2, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@vestrel00
Copy link
Owner

vestrel00 commented Jan 2, 2022

Ohh boy, am I excited about this little nice idea! It should be a pretty straightforward copy-paste-modify of the existing customdata-handlename module. The effort is minimal but the fun and joy is OPTIMAL!

This API will allow you to add pokemons to your real life contacts! The process will be a bit manual because this library will NOT pull data from the PokeAPI nor does it check for any custom data added by the Pokemon Go app/game. It is a nice proof-of-concept though on how we can integrate pokemons to real life contacts!

Usage would look something like...

contact.addPokemon {
   name = "ditto"
   nickname = "copy-cat"
   level = 24
   pokeApiId = 132
}

I AM EXCITED 🔥 🔥 🔥 🔥

  • Complete new module; customdata-pokemon
  • Add howto page
  • Update howto pages
  • Update README
@vestrel00 vestrel00 added enhancement New feature or request good first issue Good for newcomers labels Jan 2, 2022
@vestrel00 vestrel00 added this to the Additional features for v1 milestone Jan 2, 2022
@vestrel00 vestrel00 self-assigned this Jan 2, 2022
@vestrel00 vestrel00 removed their assignment Jan 3, 2022
@vestrel00 vestrel00 changed the title Custom data support for Pokemons! Support for Pokemon custom data! Jan 4, 2022
@vestrel00 vestrel00 changed the title Support for Pokemon custom data! Pokemon custom data! Jan 4, 2022
@DriblingTrex
Copy link

Hey @vestrel00 I want to do this task. I want to do this because recently I am learning to call API in a app.

@vestrel00
Copy link
Owner Author

vestrel00 commented Jan 4, 2022

@DriblingTrex, thanks for your interest in this issue! First, could you please fix your commits not being linked to your GitHub account? I would really appreciate it if you first show up as a contributor for the work that you've done before you do this task.

Screen Shot 2022-01-04 at 7 58 35 AM

We discussed more about this in your previous PRs; #133 (comment)

@vestrel00 vestrel00 pinned this issue Feb 3, 2022
vestrel00 added a commit that referenced this issue Feb 17, 2022
vestrel00 added a commit that referenced this issue Feb 18, 2022
@vestrel00 vestrel00 unpinned this issue Feb 18, 2022
@vestrel00
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants