Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify API for querying for Accounts #153

Closed
3 tasks done
vestrel00 opened this issue Dec 28, 2021 · 2 comments
Closed
3 tasks done

Simplify API for querying for Accounts #153

vestrel00 opened this issue Dec 28, 2021 · 2 comments
Assignees
@vestrel00
Labels
breaking change This may break integration of the library for some consumers refactor This may involve a refactor

Comments

@vestrel00
Copy link
Owner

vestrel00 commented Dec 28, 2021 •
edited
Loading

While working on #147 in preparation for #144 and #145, I noticed that the AccountsQuery can be simplified to adhere to the pattern followed by the other APIs in the library.

The API can be simplified to,

val result = accountsQuery
      .withTypes("com.google", "com.hotmail")
      .associatedWith(rawContact1, rawContact2)
      .find()
@vestrel00 vestrel00 added refactor This may involve a refactor breaking change This may break integration of the library for some consumers labels Dec 28, 2021
@vestrel00 vestrel00 self-assigned this Dec 28, 2021
@vestrel00
Copy link
Owner Author

This will be closed in scope of #147

vestrel00 added a commit that referenced this issue Dec 29, 2021
@vestrel00
Closes #153 Simplify API for querying for Accounts
09e92f5
@vestrel00 vestrel00 mentioned this issue Dec 29, 2021
Merged
@vestrel00 vestrel00 mentioned this issue Dec 30, 2021
Merged
@vestrel00
Copy link
Owner Author

Included in release; https://github.com/vestrel00/contacts-android/releases/tag/0.1.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vestrel00 vestrel00

Labels
breaking change This may break integration of the library for some consumers refactor This may involve a refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vestrel00