Filter pushdown optimization. #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPWstatic
added
do not review
|
Unit testing passed. |
|
Unit testing passed. |
|
Unit testing passed. |
CPWstatic
force-pushed
the
filter_pushdown
branch
from
528440e to
98185d9
Compare
|
Unit testing passed. |
laura-ding
previously approved these changes
Sep 26, 2019
CPWstatic
force-pushed
the
filter_pushdown
branch
from
98185d9 to
b0f8f37
Compare
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
|
Unit testing failed. |
1 similar comment
|
Unit testing failed. |
CPWstatic
force-pushed
the
filter_pushdown
branch
from
eebf13d to
756e0d7
Compare
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
dangleptr
reviewed
Dec 11, 2019
| std::function<OptVariantType()> getEdgeRank; | ||
| std::function<OptVariantType(const std::string&)> getInputProp; | ||
| std::function<OptVariantType(const std::string&)> getVariableProp; | ||
| std::function<OptVariantType(const std::string&, const std::string&)> getSrcTagProp; |
There was a problem hiding this comment.
Could we add some other interfaces like:
std::function<OptVariantType(TagID id, const std::string&)> getSrcTagProp
std::function<OptVariantType(EdgeType type, const std::string&)> getEdgeProp;
dangleptr
reviewed
Dec 11, 2019
There was a problem hiding this comment.
To be honest, your rewrite logic looks some bit weird.
Typically, the recursive program should looks like this:
Expression* rewrite(Expression* expr) {
switch (expr->type()) {
case kLogic:
auto* left = rewrite(expr->left());
auto* write = rewrite(expr->right());
return new LogicExpr(left, right);
case ...
}
}
wdyt?
CPWstatic
force-pushed
the
filter_pushdown
branch
from
f006197 to
100f736
Compare
|
Unit testing passed. |
dangleptr
reviewed
Dec 17, 2019
|
Unit testing passed. |
CPWstatic
force-pushed
the
filter_pushdown
branch
from
3ca3801 to
6b5d026
Compare
|
Unit testing passed. |
CPWstatic
force-pushed
the
filter_pushdown
branch
from
6b5d026 to
9c93643
Compare
|
Unit testing passed. |
dangleptr
approved these changes
Dec 20, 2019
laura-ding
approved these changes
Dec 20, 2019
| return buf; | ||
| } | ||
|
|
||
| OptVariantType AliasPropertyExpression::eval() const { | ||
| return context_->getters().getAliasProp(*alias_, *prop_); | ||
| OptVariantType AliasPropertyExpression::eval(Getters &getters) const { |
|
Unit testing passed. |
|
relate to #175 |
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* Filter push down. * Rewrite and. * Add test. * Rewrite xor,or. * Not rewrite xor and add tests. * Add test. * Rebase and fix conflict. * Fix encode/decode for expression. * Make getters thread safe. * Fix get reserved prop in key. * Rebase and fix conflict. * Add gflags to tell if pushdown filter. * Address @dangleptr's comment. * Push down functions. * Test push down filter or not. * Add ut for testing push down function. Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> Co-authored-by: panda-sheep <59197347+panda-sheep@users.noreply.github.com> Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filter pushdown optimization is based on rewriting filter. Purpose of this pr is about to enhance the performance.