-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto install dependences #944
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done.
build_dep.sh
Outdated
popd | ||
wget $url_addr/vs-nebula-3rdparty.fc.x86_64.rpm | ||
sudo rpm -ivh vs-nebula-3rdparty.fc.x86_64.rpm | ||
echo "alias cmake='cmake -DNEBULA_GPERF_BIN_DIR=/opt/nebula/gperf/bin -DNEBULA_FLEX_ROOT=/opt/nebula/flex -DNEBULA_BOOST_ROOT=/opt/nebula/boost -DNEBULA_OPENSSL_ROOT=/opt/nebula/openssl -DNEBULA_KRB5_ROOT=/opt/nebula/krb5 -DNEBULA_LIBUNWIND_ROOT=/opt/nebula/libunwind ..'" >> ~/.bashrc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the ..
directory in the end of the alias command needed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not update PATH
env variable to replace alias cmake
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has cmake args
Unit testing failed. |
jenkins go |
Unit testing passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Unit testing passed. |
closes #880 |
* Add auto install dependences * Modify docs * Modify docs * Add fedora * address dutor and yixinglu's comments
* Stop scanV -> scanE optRule when buildPath delete: av->traverse->scanV add: project-> limit -> av->traverse->sv add: project-> av ->traverse->sv exclude optRule for buildPath in project.colums() Comments added lint: clang-format [WIP] Fixing regression when return e, e.foo.bar The limit info is lost in this case Fix after vesoft-inc#4146 OptGroup was refactored in vesoft-inc#4146 Removed GetEdgesTransformRule * Rebase on vesoft-inc#4277 Remove useless AppendVertices As this rule only aplied for match ()-[e]->() return e limit 1 when 1. there is no index on e and 2. limit cluase exists, thus we could assert that AppendVertices will be removed by EliminateAppendVerticesRule // Tranformation: // Before: // +---------+---------+ // | Project | // +---------+---------+ // | // +---------+---------+ // | Limit | // +---------+---------+ // | // +---------+---------+ // | Traverse | // +---------+---------+ // | // +---------+---------+ // | ScanVertices | // +---------+---------+ // // After: // +---------+---------+ // | Project | // +---------+---------+ // | // +---------+---------+ // | Limit | // +---------+---------+ // | // +---------+---------+ // | Project | // +---------+---------+ // | // +---------+---------+ // | ScanEdges | // +---------+---------+ * Addressing Shylock-Hg's comment * Make linter happy * Fix after EliminateAppendVerticesRule merged and linting * Reusing functions in GetEdgesTransformRule * Addressing comment from Shylock-Hg & rebase Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com> Co-authored-by: Wey Gu <weyl.gu@gmail.com> Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com>
fedora
,centos7
,centos6
,ubuntu16
,ubuntu18
fedora