Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto install dependences #944

Merged
merged 6 commits into from
Sep 23, 2019
Merged

Add auto install dependences #944

merged 6 commits into from
Sep 23, 2019

Conversation

laura-ding
Copy link
Contributor

@laura-ding laura-ding commented Sep 17, 2019

  1. Add third-party package for fedora, centos7, centos6, ubuntu16, ubuntu18
  2. Add tool package for fedora

@laura-ding laura-ding added the ready-for-testing PR: ready for the CI test label Sep 19, 2019
dutor
dutor previously approved these changes Sep 19, 2019
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done.

build_dep.sh Outdated
popd
wget $url_addr/vs-nebula-3rdparty.fc.x86_64.rpm
sudo rpm -ivh vs-nebula-3rdparty.fc.x86_64.rpm
echo "alias cmake='cmake -DNEBULA_GPERF_BIN_DIR=/opt/nebula/gperf/bin -DNEBULA_FLEX_ROOT=/opt/nebula/flex -DNEBULA_BOOST_ROOT=/opt/nebula/boost -DNEBULA_OPENSSL_ROOT=/opt/nebula/openssl -DNEBULA_KRB5_ROOT=/opt/nebula/krb5 -DNEBULA_LIBUNWIND_ROOT=/opt/nebula/libunwind ..'" >> ~/.bashrc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the .. directory in the end of the alias command needed ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not update PATH env variable to replace alias cmake?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has cmake args

@nebula-community-bot
Copy link
Member

Unit testing failed.

@laura-ding
Copy link
Contributor Author

jenkins go

@nebula-community-bot
Copy link
Member

Unit testing passed.

Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@monadbobo monadbobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit 89e6a89 into vesoft-inc:master Sep 23, 2019
@yixinglu
Copy link
Contributor

closes #880

tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* Add auto install dependences

* Modify docs

* Modify docs

* Add fedora

* address dutor and yixinglu's comments
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
* Stop scanV -> scanE optRule when buildPath

delete: av->traverse->scanV
add: project-> limit -> av->traverse->sv
add: project-> av ->traverse->sv

exclude optRule for buildPath in project.colums()

Comments added

lint: clang-format

[WIP] Fixing regression when return e, e.foo.bar

The limit info is lost in this case

Fix after vesoft-inc#4146

OptGroup was refactored in vesoft-inc#4146

Removed GetEdgesTransformRule

* Rebase on vesoft-inc#4277 Remove useless AppendVertices

As this rule only aplied for
   match ()-[e]->() return e limit 1
when 1. there is no index on e and 2. limit cluase
exists, thus we could assert that AppendVertices
will be removed by EliminateAppendVerticesRule

//  Tranformation:
//  Before:
// +---------+---------+
// |      Project      |
// +---------+---------+
//           |
// +---------+---------+
// |       Limit       |
// +---------+---------+
//           |
// +---------+---------+
// |      Traverse     |
// +---------+---------+
//           |
// +---------+---------+
// |    ScanVertices   |
// +---------+---------+
//
//  After:
// +---------+---------+
// |      Project      |
// +---------+---------+
//           |
// +---------+---------+
// |       Limit       |
// +---------+---------+
//           |
// +---------+---------+
// |      Project      |
// +---------+---------+
//           |
// +---------+---------+
// |      ScanEdges    |
// +---------+---------+

* Addressing Shylock-Hg's comment

* Make linter happy

* Fix after EliminateAppendVerticesRule merged

and linting

* Reusing functions in GetEdgesTransformRule

* Addressing comment from Shylock-Hg & rebase

Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com>

Co-authored-by: Wey Gu <weyl.gu@gmail.com>
Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants