rewrite none_direct_dst(e) to e._dst #5287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jievince
requested review from
czpmango,
codesigner,
xtcyclist,
nevermore3 and
Shylock-Hg
Shylock-Hg
reviewed
Jan 30, 2023
| @@ -73,24 +153,25 @@ Feature: Push Filter down Traverse rule | |||
| Scenario: push filter down Traverse with complex filter | |||
| When profiling query: | |||
| """ | |||
| MATCH (v:player)-[e:like]->(v2) WHERE v.player.age != 35 and (e.likeness + 100) != 199 | |||
There was a problem hiding this comment.
Adds and none_direct_dst(e) in ["Tony Parker", "Tim Duncan", "Yao Ming"] to make the filter more complex
There was a problem hiding this comment.
We should avoid to change origin test cases, better to add new one.
|
This should be doc related, right? |
jievince
force-pushed
the
rewrite-none-direct-srcdst
branch
from
7746d3b to
a0acc46
Compare
Yes |
yixinglu
approved these changes
Jan 30, 2023
Shylock-Hg
approved these changes
Jan 30, 2023
|
quote @jievince 's description to
|
Sophie-Xie
removed
the
doc affected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Close #5286
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: