Support show create tag/edge xxx, show create space xxx SQL #496

ayyt · 2019-06-04T14:17:41Z

Support show create tag/edge xxx, show create space xxx SQL
Close #439

This PR contain TTL_schema (PR #422). Because it depends on the attributes of the schema.

nebula-community-bot · 2019-06-04T14:17:50Z

Can one of the admins verify this patch?

ayyt · 2019-06-05T14:31:21Z

Please code review, thx.

laura-ding · 2019-06-06T02:44:59Z

src/graph/CreateEdgeExecutor.cpp

+                    break;
+            }
+        }
+        if (schema_.schema_prop.ttl_duration != 0) {


Please put this in setTTLDuration()

no, no. when only set ttl_col, the ttl_duration is default 0.

This situation is implicit ttl, which is forbidden here.

SQL like：
create tag t ( a int) ttl_duration = 10; we don't support.

laura-ding · 2019-06-06T02:51:55Z

src/graph/CreateTagExecutor.cpp

+            }
+        }
+
+        if (schema_.schema_prop.ttl_duration != 0) {


when onlyse set ttl_col, the ttl_duration is default 0.

This situation is implicit ttl, which is forbidden here.

SQL like：
create tag t ( a int) ttl_duratuion = 10; we don't support.

laura-ding · 2019-06-06T03:06:20Z

src/graph/CreateTagExecutor.cpp

-    auto future = mc->createTagSchema(spaceId, *name, schema);
+    // set schema_.schema_prop default
+    // 0 means infinity
+    schema_.schema_prop.set_ttl_duration(0);


It can init in the constructor of schema_prop

👍👍👍，good catch！

laura-ding · 2019-06-06T03:08:48Z

src/graph/DescribeSpaceExecutor.cpp

- * This source code is licensed under Apache 2.0 License
- *  (found in the LICENSE.Apache file in the root directory)
+ * This source code is licensed under Apache 2.0 License,
+ * attached with Common Clause Condition 1.0, found in the LICENSES directory.


ayyt · 2019-06-19T10:06:45Z

rebase master. please code review again, thx

whitewum

is this a mixed pr? should I wait for #422?

whitewum · 2019-06-20T12:08:41Z

src/parser/AdminSentences.cpp

@@ -96,12 +102,14 @@ std::string CreateSpaceSentence::toString() const {
    return buf;
 }

+
 std::string DropSpaceSentence::toString() const {


const std::string

Never qualify with const when you return by value.

ayyt · 2019-06-20T12:37:34Z

is this a mixed pr? should I wait for #422?

Yeah, the pr contains PR #422.
After pr 422 merged, I will update this PR.

nebula-community-bot · 2019-06-28T10:02:19Z

Unit testing failed.

nebula-community-bot · 2019-06-28T10:25:20Z

Unit testing failed.

ayyt · 2019-06-28T13:35:48Z

Jenkins, go

nebula-community-bot · 2019-07-29T02:34:51Z

Unit testing passed.

ayyt · 2019-07-31T05:53:26Z

Jenkins, go

nebula-community-bot · 2019-07-31T06:12:18Z

Unit testing passed.

ayyt · 2019-08-13T06:44:10Z

Rebase master, please review, thx.

laura-ding · 2019-08-13T07:07:54Z

src/graph/ShowExecutor.cpp

@@ -19,7 +19,14 @@ ShowExecutor::ShowExecutor(Sentence *sentence,


 Status ShowExecutor::prepare() {
-    return Status::OK();
+    if (sentence_->showType() == ShowSentence::ShowType::kShowTags ||


please see pr #740

Good catch, 👍👍

nebula-community-bot · 2019-08-13T07:08:00Z

Unit testing passed.

nebula-community-bot · 2019-08-13T07:43:37Z

Unit testing passed.

support time to live alter tag/edge drop column, and the column to be delete is as TTL column address dangleptr's comment

ayyt · 2019-08-13T08:09:48Z

Jenkins, go!

ayyt · 2019-08-13T08:10:19Z

Fix and rebase master. Please review again, thx.

laura-ding

Well done

nebula-community-bot · 2019-08-13T09:27:26Z

Unit testing passed.

nebula-community-bot · 2019-08-13T09:35:44Z

Unit testing passed.

CPWstatic

LGTM.

nebula-community-bot · 2019-08-15T02:34:24Z

Unit testing passed.

…nc#496) * improve unreserved keywords feature support time to live alter tag/edge drop column, and the column to be delete is as TTL column address dangleptr's comment * address laura-ding's comments * rebase master

ayyt changed the title ~~Show create tag edge space~~ Support show create tag/edge xxx, show create space xxx SQL Jun 4, 2019

ayyt mentioned this pull request Jun 5, 2019

Ttl schema #422

Merged

ayyt force-pushed the show_create_tag_edge_space branch from 2743b1c to 0aa85d3 Compare June 5, 2019 14:29

dangleptr mentioned this pull request Jun 6, 2019

Show Create Tag and Edge #497

Closed

laura-ding reviewed Jun 6, 2019

View reviewed changes

ayyt force-pushed the show_create_tag_edge_space branch 8 times, most recently from 6634a04 to 83c97fe Compare June 19, 2019 09:37

ayyt added the ready-for-testing PR: ready for the CI test label Jun 19, 2019

whitewum reviewed Jun 20, 2019

View reviewed changes

ayyt force-pushed the show_create_tag_edge_space branch from 83c97fe to a7285f7 Compare June 20, 2019 13:31

ayyt force-pushed the show_create_tag_edge_space branch from a7285f7 to 05d8f0e Compare June 28, 2019 09:12

ayyt force-pushed the show_create_tag_edge_space branch from 05d8f0e to 96d2c71 Compare June 28, 2019 10:16

ayyt added the in progress label Jun 28, 2019

ayyt removed the ready-for-testing PR: ready for the CI test label Jun 28, 2019

ayyt force-pushed the show_create_tag_edge_space branch 2 times, most recently from 8dfda1b to b0ff8f8 Compare June 28, 2019 13:33

ayyt added the ready-for-testing PR: ready for the CI test label Jun 28, 2019

ayyt force-pushed the show_create_tag_edge_space branch from cef903a to 190b5fb Compare August 13, 2019 06:43

ayyt force-pushed the show_create_tag_edge_space branch from 190b5fb to f8c0f81 Compare August 13, 2019 06:45

laura-ding reviewed Aug 13, 2019

View reviewed changes

jude-zhu requested review from CPWstatic, dutor and whitewum August 13, 2019 07:13

jude-zhu requested review from dangleptr and laura-ding August 13, 2019 07:47

ayyt force-pushed the show_create_tag_edge_space branch from f8c0f81 to 95ba55f Compare August 13, 2019 08:08

ayyt added 3 commits August 13, 2019 16:08

improve unreserved keywords feature

3375fdb

support time to live alter tag/edge drop column, and the column to be delete is as TTL column address dangleptr's comment

address laura-ding's comments

433f9b7

rebase master

b365641

ayyt force-pushed the show_create_tag_edge_space branch from 95ba55f to b365641 Compare August 13, 2019 08:09

laura-ding approved these changes Aug 13, 2019

View reviewed changes

CPWstatic approved these changes Aug 14, 2019

View reviewed changes

Merge branch 'master' into show_create_tag_edge_space

a3f2a7b

dutor merged commit d8c7fd8 into vesoft-inc:master Aug 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support show create tag/edge xxx, show create space xxx SQL #496

Support show create tag/edge xxx, show create space xxx SQL #496

ayyt commented Jun 4, 2019 •

edited

Loading

nebula-community-bot commented Jun 4, 2019

ayyt commented Jun 5, 2019

laura-ding Jun 6, 2019

ayyt Jun 6, 2019 •

edited

Loading

laura-ding Jun 6, 2019

ayyt Jun 6, 2019 •

edited

Loading

laura-ding Jun 6, 2019

ayyt Jun 6, 2019

laura-ding Jun 6, 2019

ayyt commented Jun 19, 2019

whitewum left a comment

whitewum Jun 20, 2019

ayyt Jun 20, 2019

ayyt commented Jun 20, 2019

nebula-community-bot commented Jun 28, 2019

nebula-community-bot commented Jun 28, 2019

ayyt commented Jun 28, 2019

nebula-community-bot commented Jul 29, 2019

ayyt commented Jul 31, 2019

nebula-community-bot commented Jul 31, 2019

ayyt commented Aug 13, 2019

laura-ding Aug 13, 2019

ayyt Aug 13, 2019

nebula-community-bot commented Aug 13, 2019

nebula-community-bot commented Aug 13, 2019

ayyt commented Aug 13, 2019

ayyt commented Aug 13, 2019

laura-ding left a comment

nebula-community-bot commented Aug 13, 2019

nebula-community-bot commented Aug 13, 2019

CPWstatic left a comment

nebula-community-bot commented Aug 15, 2019

Support show create tag/edge xxx, show create space xxx SQL #496

Support show create tag/edge xxx, show create space xxx SQL #496

Conversation

ayyt commented Jun 4, 2019 • edited Loading

nebula-community-bot commented Jun 4, 2019

ayyt commented Jun 5, 2019

Choose a reason for hiding this comment

ayyt Jun 6, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ayyt Jun 6, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ayyt commented Jun 19, 2019

whitewum left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ayyt commented Jun 20, 2019

nebula-community-bot commented Jun 28, 2019

nebula-community-bot commented Jun 28, 2019

ayyt commented Jun 28, 2019

nebula-community-bot commented Jul 29, 2019

ayyt commented Jul 31, 2019

nebula-community-bot commented Jul 31, 2019

ayyt commented Aug 13, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nebula-community-bot commented Aug 13, 2019

nebula-community-bot commented Aug 13, 2019

ayyt commented Aug 13, 2019

ayyt commented Aug 13, 2019

laura-ding left a comment

Choose a reason for hiding this comment

nebula-community-bot commented Aug 13, 2019

nebula-community-bot commented Aug 13, 2019

CPWstatic left a comment

Choose a reason for hiding this comment

nebula-community-bot commented Aug 15, 2019

ayyt commented Jun 4, 2019 •

edited

Loading

ayyt Jun 6, 2019 •

edited

Loading

ayyt Jun 6, 2019 •

edited

Loading