Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
UPDATE CONFIGS
statement will lead to storage crash when update rocksdb configs.Issue(s) number:
Description:
In the test
test_configs
, we will try to modify the value ofstorage:rocksdb_column_family_options
. And we save the value as anExpression
after parser. In this case, it's aMap
.Then,
gflags
only accepts string type value. We transfer theValue::Map
tomap<std::string,std::string>
. But we add extra quotes. For example,a:1
while be transferred to"a":"1"
, butb:"x"
will be transferred to"b":""x""
, which is error format for json.But I still don't know why this problem is not triggered in our CI.
A preliminary guess is that the update of config will wait for the metaClient to pull regularly. The interval between two modifications is too short, so the metaClient does not find this modification.
How do you solve it?
I modified the value written in restore, so that the 'test_configs' case will not report an error, but the subsequent case will fail when creating a space. It can only be regarded as a temporary solution.
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: