Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the build #449

Merged
merged 2 commits into from
May 30, 2019
Merged

Fixed the build #449

merged 2 commits into from
May 30, 2019

Conversation

sherman-the-tank
Copy link
Member

Some linux releases have turned on _FORTIFY_SOURCE=2, which broke our build. This PR tries to fix it

Some linux releases have turned on _FORTIFY_SOURCE=2, which broke our build. This PR tries to fix it
@sherman-the-tank
Copy link
Member Author

jenkins go

@sherman-the-tank sherman-the-tank added the ready-for-testing PR: ready for the CI test label May 28, 2019
@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor
Copy link
Contributor

dutor commented May 30, 2019

As we have discussed, we should add the _FORTIFY_SOURCE explicitly to avoid such inconsistency between platforms.

@sherman-the-tank
Copy link
Member Author

Fix #474

@nebula-community-bot
Copy link
Member

Unit testing passed.

@laura-ding laura-ding merged commit 29c95b4 into vesoft-inc:master May 30, 2019
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
Some linux releases have turned on _FORTIFY_SOURCE=2, which broke our build. This PR tries to fix it
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
#### What type of PR is this?
- [x] bug
- [ ] feature
- [ ] enhancement

#### What does this PR do?
closes vesoft-inc#3441 
simplify graphd signal handler:Set stop condition instead of waiting all workers stop

#### Which issue(s)/PR(s) this PR relates to?
In vesoft-inc#3437 , it simplify storage SIGINT signal handler
  
#### Special notes for your reviewer, ex. impact of this fix, etc:


#### Additional context/ Design document:


#### Checklist:
- [ ] Documentation affected (Please add the label if documentation needs to be modified.)
- [ ] Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.)
- [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
- [ ] Performance impacted: Consumes more CPU/Memory

#### Release notes:

Please confirm whether to be reflected in release notes and how to describe:
>                                                                 `


Migrated from vesoft-inc#3542

Co-authored-by: endy.li <25311962+heroicNeZha@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants