-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the build #449
Merged
laura-ding
merged 2 commits into
vesoft-inc:master
from
sherman-the-tank:fix-build-fortified-source
May 30, 2019
Merged
Fixed the build #449
laura-ding
merged 2 commits into
vesoft-inc:master
from
sherman-the-tank:fix-build-fortified-source
May 30, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some linux releases have turned on _FORTIFY_SOURCE=2, which broke our build. This PR tries to fix it
jenkins go |
Unit testing passed. |
dutor
approved these changes
May 30, 2019
As we have discussed, we should add the _FORTIFY_SOURCE explicitly to avoid such inconsistency between platforms. |
Fix #474 |
laura-ding
approved these changes
May 30, 2019
Unit testing passed. |
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
Some linux releases have turned on _FORTIFY_SOURCE=2, which broke our build. This PR tries to fix it
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
#### What type of PR is this? - [x] bug - [ ] feature - [ ] enhancement #### What does this PR do? closes vesoft-inc#3441 simplify graphd signal handler:Set stop condition instead of waiting all workers stop #### Which issue(s)/PR(s) this PR relates to? In vesoft-inc#3437 , it simplify storage SIGINT signal handler #### Special notes for your reviewer, ex. impact of this fix, etc: #### Additional context/ Design document: #### Checklist: - [ ] Documentation affected (Please add the label if documentation needs to be modified.) - [ ] Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.) - [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).) - [ ] Performance impacted: Consumes more CPU/Memory #### Release notes: Please confirm whether to be reflected in release notes and how to describe: > ` Migrated from vesoft-inc#3542 Co-authored-by: endy.li <25311962+heroicNeZha@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some linux releases have turned on _FORTIFY_SOURCE=2, which broke our build. This PR tries to fix it