check god role exist when meta init #4330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevermore3
added
ready-for-testing
SuperYoko
reviewed
Jun 17, 2022
SuperYoko
suggested changes
Jun 17, 2022
SuperYoko
approved these changes
Jun 17, 2022
critical27
approved these changes
Jun 17, 2022
|
Good job~ |
nebula-bots
pushed a commit
that referenced
this pull request
Jun 23, 2022
* check god role exist when meta init * return error if kv fail Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
11 tasks
Sophie-Xie
pushed a commit
that referenced
this pull request
Jun 27, 2022
* check god role exist when meta init * return error if kv fail Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Sophie-Xie
added a commit
that referenced
this pull request
Jun 27, 2022
* force cache the docker layer (#4331) * check god role exist when meta init (#4330) * check god role exist when meta init * return error if kv fail Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> * Fix object pool mtsafe. (#4332) * Fix object pool mtsafe. * Fix lock. * Fixed web service crash (#4334) Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * Fix get edges transform rule. (#4328) 1. Input/Ouput variables. 2. Keep column names of Limit same with input plan node. Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * fix rc docker (#4336) * add lock (#4352) * fix map concurrency issue (#4344) * fix mutex in map * add test * move the order Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * add stats under index conditions (#4353) Co-authored-by: Harris.Chu <1726587+HarrisChu@users.noreply.github.com> Co-authored-by: jimingquan <mingquan.ji@vesoft.com> Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com> Co-authored-by: dutor <440396+dutor@users.noreply.github.com> Co-authored-by: panda-sheep <59197347+panda-sheep@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
close https://github.com/vesoft-inc/nebula-ent/issues/957
Description:
Before:
it will check whether there is a root account，when meta is restarted
After:
it will check whether there is an account with the GOD role， when the meta is restarted
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: