Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug: I guess storage may core #4196

Merged
merged 2 commits into from
Apr 23, 2022
Merged

Conversation

liuyu85cn
Copy link
Contributor

@liuyu85cn liuyu85cn commented Apr 22, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

fix two issues

  1. @wenhaocs talked to me offline a batch holder not used properly. thanks wenhao.
  2. I find if atomic op run twice, it may core.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

@liuyu85cn liuyu85cn added ready-for-testing PR: ready for the CI test ready for review labels Apr 22, 2022
Copy link
Contributor

@wenhaocs wenhaocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@Sophie-Xie Sophie-Xie added the cherry-pick-v3.1 PR: need cherry-pick to this version label Apr 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4196 (5e27cd3) into master (4112c7d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4196      +/-   ##
==========================================
+ Coverage   84.91%   84.94%   +0.03%     
==========================================
  Files        1321     1321              
  Lines      131235   131248      +13     
==========================================
+ Hits       111434   111491      +57     
+ Misses      19801    19757      -44     
Impacted Files Coverage Δ
src/storage/mutate/AddVerticesProcessor.h 100.00% <ø> (ø)
src/storage/mutate/AddVerticesProcessor.cpp 84.18% <100.00%> (-1.03%) ⬇️
src/meta/processors/parts/GetSpaceProcessor.cpp 61.29% <0.00%> (-19.36%) ⬇️
src/graph/executor/StorageAccessExecutor.h 57.77% <0.00%> (-2.23%) ⬇️
src/meta/processors/parts/ListHostsProcessor.cpp 70.35% <0.00%> (-2.22%) ⬇️
src/parser/GraphScanner.h 92.63% <0.00%> (-2.00%) ⬇️
src/common/base/Status.h 90.56% <0.00%> (-1.89%) ⬇️
src/common/expression/LogicalExpression.cpp 91.89% <0.00%> (-1.81%) ⬇️
src/graph/service/PermissionCheck.cpp 79.59% <0.00%> (-1.66%) ⬇️
src/codec/RowReaderWrapper.cpp 78.57% <0.00%> (-1.64%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4112c7d...5e27cd3. Read the comment docs.

@critical27
Copy link
Contributor

@kikimo Would you approve it after this PR verified?

@Sophie-Xie
Copy link
Contributor

@kikimo Would you approve it after this PR verified?

I will merge it after verify.

@Sophie-Xie Sophie-Xie merged commit dc6b8d8 into vesoft-inc:master Apr 23, 2022
Sophie-Xie added a commit that referenced this pull request Apr 23, 2022
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.1 PR: need cherry-pick to this version ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants