-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a bug: I guess storage may core #4196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
Codecov Report
@@ Coverage Diff @@
## master #4196 +/- ##
==========================================
+ Coverage 84.91% 84.94% +0.03%
==========================================
Files 1321 1321
Lines 131235 131248 +13
==========================================
+ Hits 111434 111491 +57
+ Misses 19801 19757 -44
Continue to review full report at Codecov.
|
@kikimo Would you approve it after this PR verified? |
I will merge it after verify. |
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
fix two issues
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes: