Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor job manager part3 #4045

Merged
merged 4 commits into from
Mar 17, 2022

Conversation

panda-sheep
Copy link
Contributor

@panda-sheep panda-sheep commented Mar 17, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

rename AdminCmd to JobType,
1) adminclient not only handles jobs, but also other handles commands. So the AdminCmd here is easily misunderstood.
2) AdminCmd is just the type of job,It is more appropriate to use JobType

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@panda-sheep panda-sheep requested review from CPWstatic, dutor and a team as code owners March 17, 2022 07:12
@panda-sheep panda-sheep force-pushed the refactor_job_manager_3 branch from ad1d3a1 to c8f10c3 Compare March 17, 2022 07:24
@panda-sheep panda-sheep force-pushed the refactor_job_manager_3 branch from c8f10c3 to 158afef Compare March 17, 2022 07:31
@panda-sheep panda-sheep added ready-for-testing PR: ready for the CI test ready for review labels Mar 17, 2022
Copy link
Contributor

@liuyu85cn liuyu85cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@Sophie-Xie Sophie-Xie merged commit c41f53d into vesoft-inc:master Mar 17, 2022
@panda-sheep panda-sheep deleted the refactor_job_manager_3 branch March 18, 2022 01:22
@Sophie-Xie Sophie-Xie mentioned this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants