Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lambda capture bug in GraphStorageLocalServer #4000

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

yixinglu
Copy link
Contributor

This will crash the daemon

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

The request object in lambda function is captured by reference, this will crash the server when this async interface finishes to run and the task in threadManager haven't be executed.

How do you solve it?

Captured by copy.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@yixinglu yixinglu added ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected labels Mar 10, 2022
@yixinglu yixinglu force-pushed the fix-standalone-local-server branch from ad4a3af to bb19cc1 Compare March 10, 2022 06:13
@yixinglu yixinglu force-pushed the fix-standalone-local-server branch from bb19cc1 to ca30871 Compare March 10, 2022 06:14
Copy link
Contributor

@SuperYoko SuperYoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If request won't cost too much,capture by value is better.
I'm okay with this fix, thanks.

@yixinglu yixinglu merged commit 138e587 into vesoft-inc:master Mar 10, 2022
@yixinglu yixinglu deleted the fix-standalone-local-server branch March 10, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants