Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tck ssl client #3471

Closed
wants to merge 1 commit into from
Closed

Conversation

HarrisChu
Copy link
Contributor

@HarrisChu HarrisChu commented Dec 15, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

use ssl client in tck test
Close #3433

should not be merged utils nebula-python support password

@HarrisChu HarrisChu added the ready-for-testing PR: ready for the CI test label Dec 15, 2021
@HarrisChu HarrisChu requested a review from Shylock-Hg December 15, 2021 05:42
tests/common/utils.py Outdated Show resolved Hide resolved
@HarrisChu
Copy link
Contributor Author

#3433

@codecov-commenter
Copy link

Codecov Report

Merging #3471 (62391c0) into master (9a0fbb6) will decrease coverage by 0.16%.
The diff coverage is 86.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3471      +/-   ##
==========================================
- Coverage   85.40%   85.24%   -0.17%     
==========================================
  Files        1289     1304      +15     
  Lines      119798   121239    +1441     
==========================================
+ Hits       102317   103347    +1030     
- Misses      17481    17892     +411     
Impacted Files Coverage Δ
src/clients/meta/MetaClient.h 95.65% <ø> (ø)
src/common/graph/Response.h 45.66% <ø> (ø)
src/common/time/TimezoneInfo.cpp 50.00% <ø> (+4.54%) ⬆️
src/graph/executor/admin/AddHostsExecutor.cpp 0.00% <0.00%> (ø)
src/graph/executor/admin/AddHostsExecutor.h 0.00% <0.00%> (ø)
src/graph/executor/admin/DropHostsExecutor.cpp 0.00% <0.00%> (ø)
src/graph/executor/admin/DropHostsExecutor.h 0.00% <0.00%> (ø)
src/graph/executor/admin/ShowHostsExecutor.h 100.00% <ø> (ø)
src/graph/optimizer/rule/IndexScanRule.cpp 87.80% <ø> (+1.13%) ⬆️
src/graph/planner/plan/Admin.cpp 52.45% <0.00%> (-3.69%) ⬇️
... and 142 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df3781c...62391c0. Read the comment docs.

@Shylock-Hg Shylock-Hg mentioned this pull request Dec 27, 2021
7 tasks
@@ -450,3 +455,18 @@ def parse_service_index(name: str):
if m and len(m.groups()) == 2:
return int(m.groups()[1])
return None

def get_ssl_config(is_graph_ssl: bool, ca_signed: bool):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add this function?

_params['ca_path'] = 'share/resources/test.ca.pem'
_params['cert_path'] = 'share/resources/test.ca.key'
_params['key_path'] = 'share/resources/test.ca.password'
_params['cert_path'] = 'share/resources/test.derive.crt'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

            _params['cert_path'] = 'share/resources/test.ca.pem'
            _params['key_path'] = 'share/resources/test.ca.key'
            _params['password_path'] = 'share/resources/test.ca.password'

@HarrisChu HarrisChu closed this Dec 28, 2021
@HarrisChu HarrisChu deleted the tck_ssl_client branch December 28, 2021 11:28
@Shylock-Hg Shylock-Hg mentioned this pull request Dec 29, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let python-client enable SSL connection in TCK/CI.
3 participants