-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support properties in where clause #3443
Support properties in where clause #3443
Conversation
cf57ea2
to
fa0180a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need not to add some TCK tests?
536fb35
to
b55fe0f
Compare
b55fe0f
to
2186f33
Compare
2186f33
to
4ac7d4f
Compare
Codecov Report
@@ Coverage Diff @@
## master #3443 +/- ##
==========================================
- Coverage 85.19% 85.19% -0.01%
==========================================
Files 1306 1307 +1
Lines 122158 122521 +363
==========================================
+ Hits 104078 104378 +300
- Misses 18080 18143 +63
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This properties(*).age
will be updated into properties(*).'player.age'
. LGTM
Add a test case like |
these testcase already exist, this PR is support the properties function in where clause |
What type of PR is this?
What does this PR do?
1、support properties function in GO sentence 's where clause
2、use DeducePropVisitor to extract the attribbute of VertexExpression & EdgeExpression
Which issue(s)/PR(s) this PR relates to?
#3117, will reconsider later
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist:
Release notes:
Please confirm whether to reflect in release notes and how to describe: