replace kVertex with kTag #3286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cangfengzhs
force-pushed
the
replace_kvertex_with_ktag
branch
from
0b8da07 to
209e646
Compare
critical27
previously approved these changes
Nov 9, 2021
Codecov Report
@@ Coverage Diff @@
## master #3286 +/- ##
==========================================
+ Coverage 85.24% 85.28% +0.03%
==========================================
Files 1305 1305
Lines 120347 120343 -4
==========================================
+ Hits 102595 102634 +39
+ Misses 17752 17709 -43
Continue to review full report at Codecov.
|
Shylock-Hg
reviewed
Nov 10, 2021
| @@ -12,12 +12,13 @@ | |||
| namespace nebula { | |||
|
|
|||
| enum class NebulaKeyType : uint32_t { | |||
| kVertex = 0x00000001, | |||
| kTag_ = 0x00000001, | |||
There was a problem hiding this comment.
kTag is defined in Base.h constexpr char kTag[] = "_tag";.And compiler will report a warning if a local variable overwrite global variables.
critical27
approved these changes
Nov 16, 2021
pengweisong
approved these changes
Nov 17, 2021
| @@ -75,14 +75,11 @@ class NebulaKeyUtils final { | |||
| /** | |||
| * Prefix for vertex | |||
There was a problem hiding this comment.
check the comment, other places may also need modify
| @@ -41,7 +42,7 @@ static typename std::enable_if<std::is_integral<T>::value, T>::type readInt(cons | |||
| } | |||
|
|
|||
| // size of vertex key except vertexId | |||
| @@ -37,7 +37,7 @@ class StorageCompactionFilter final : public kvstore::KVFilter { | |||
| return false; | |||
| } | |||
|
|
|||
| if (NebulaKeyUtils::isVertex(vIdLen_, key)) { | |||
| if (NebulaKeyUtils::isTag(vIdLen_, key)) { | |||
| return !vertexValid(spaceId, key, val); | |||
There was a problem hiding this comment.
should it be changed to tagValid?
There was a problem hiding this comment.
Okey, I will fix it in next PR.
foesa-yang
removed
the
doc affected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
Replace
KVertexwithKTag_to support vertex without tagWhich issue(s)/PR(s) this PR relates to?
#3123
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist：
Release notes：
Please confirm whether to reflect in release notes and how to describe: