Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the skip go sample test cases. #3086

Merged
merged 6 commits into from
Dec 2, 2021

Conversation

Shylock-Hg
Copy link
Contributor

No description provided.

@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label Oct 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2021

Codecov Report

Merging #3086 (4f57267) into master (ab73b4c) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3086      +/-   ##
==========================================
+ Coverage   85.23%   85.25%   +0.02%     
==========================================
  Files        1277     1277              
  Lines      119088   119100      +12     
==========================================
+ Hits       101502   101539      +37     
+ Misses      17586    17561      -25     
Impacted Files Coverage Δ
src/graph/context/Result.cpp 85.00% <0.00%> (-9.45%) ⬇️
src/graph/planner/Planner.cpp 75.00% <0.00%> (-5.00%) ⬇️
src/storage/exec/QueryUtils.h 91.42% <0.00%> (-1.78%) ⬇️
src/graph/service/PermissionCheck.cpp 78.72% <0.00%> (-1.72%) ⬇️
src/common/expression/RelationalExpression.cpp 92.38% <0.00%> (-0.95%) ⬇️
src/codec/RowReaderWrapper.cpp 78.57% <0.00%> (-0.82%) ⬇️
src/common/utils/IndexKeyUtils.h 90.93% <0.00%> (-0.58%) ⬇️
src/kvstore/RocksEngine.cpp 83.55% <0.00%> (-0.54%) ⬇️
src/common/fs/test/FileUtilsTest.cpp 99.52% <0.00%> (-0.48%) ⬇️
src/storage/query/QueryBaseProcessor-inl.h 84.59% <0.00%> (-0.46%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab73b4c...4f57267. Read the comment docs.

nevermore3
nevermore3 previously approved these changes Oct 19, 2021
critical27
critical27 previously approved these changes Nov 12, 2021
yixinglu
yixinglu previously approved these changes Nov 12, 2021
@Sophie-Xie Sophie-Xie added this to the v3.0.0 milestone Nov 17, 2021
@yixinglu yixinglu merged commit e319615 into vesoft-inc:master Dec 2, 2021
@Shylock-Hg Shylock-Hg deleted the test/enable-skip-tests branch February 9, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants