Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more check about drop zone with created space #2942

Merged

Conversation

darionyaphet
Copy link
Contributor

(root@nebula) [(none)]> add zone z1 "192.168.8.215":55501
Execution succeeded (time spent 4793/5348 us)

Mon, 27 Sep 2021 23:05:57 CST

(root@nebula) [(none)]> add group g1 z1
Execution succeeded (time spent 2695/3292 us)

Mon, 27 Sep 2021 23:06:02 CST

(root@nebula) [(none)]> create space s2 (vid_type=int, replica_factor=1, partition_num=1) on g1
Execution succeeded (time spent 3023/3567 us)

Mon, 27 Sep 2021 23:06:17 CST

(root@nebula) [(none)]> drop zone z1 from group g1
[ERROR (-1005)]: Conflict!

Mon, 27 Sep 2021 23:06:30 CST

@Sophie-Xie Sophie-Xie added this to the v2.6.0 milestone Sep 27, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2942 (5a3c932) into master (dddf54e) will decrease coverage by 0.72%.
The diff coverage is 61.94%.

❗ Current head 5a3c932 differs from pull request most recent head 6f3db5d. Consider uploading reports for the commit 6f3db5d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2942      +/-   ##
==========================================
- Coverage   85.47%   84.75%   -0.73%     
==========================================
  Files        1229     1231       +2     
  Lines      110375   110830     +455     
==========================================
- Hits        94341    93931     -410     
- Misses      16034    16899     +865     
Impacted Files Coverage Δ
src/clients/meta/MetaClient.h 92.30% <ø> (ø)
src/common/utils/NebulaKeyUtils.cpp 89.03% <0.00%> (-4.89%) ⬇️
src/common/utils/NebulaKeyUtils.h 78.02% <ø> (ø)
src/graph/planner/plan/Admin.cpp 54.23% <0.00%> (-2.40%) ⬇️
src/graph/planner/plan/PlanNode.h 80.00% <ø> (ø)
src/graph/service/PermissionCheck.cpp 83.72% <ø> (+2.32%) ⬆️
src/kvstore/KVEngine.h 100.00% <ø> (ø)
src/kvstore/RocksEngine.cpp 82.01% <0.00%> (-1.51%) ⬇️
src/kvstore/RocksEngine.h 66.66% <0.00%> (-25.00%) ⬇️
src/meta/MetaServiceHandler.h 100.00% <ø> (ø)
... and 116 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 073fb37...6f3db5d. Read the comment docs.

@bright-starry-sky bright-starry-sky merged commit c09fe47 into vesoft-inc:master Sep 28, 2021
@darionyaphet darionyaphet deleted the fix-drop-zone-with-group branch September 28, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drop zone from group should verify if hosts in zone have partitions
6 participants