improve int convert float/doulbe/bool, bool convert int, float/double conv… #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panda-sheep
requested review from
sherman-the-tank,
dutor,
bright-starry-sky,
critical27,
darionyaphet and
liuyu85cn
and removed request for
sherman-the-tank
|
In |
panda-sheep
changed the title
|
|
darionyaphet
approved these changes
Mar 26, 2021
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Sep 14, 2023
…xisted!" (vesoft-inc#2450) If user does not exist `desc user xxx` will be raise "User not existed!" <!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [x] bug - [ ] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: Close vesoft-inc#5141 #### Description: If use does not exist `desc user xxx` will be raise "User not existed!" ## How do you solve it? add account exist verify in meta service ## Special notes for your reviewer, ex. impact of this fix, design document, etc: ## Checklist: Tests: manunal test: ``` (root@nebula) [(none)]> desc user u6 [ERROR (-1005)]: User not existed! Wed, 15 Feb 2023 22:43:06 CST ``` - [ ] Unit test(positive and negative cases) - [ ] Function test - [ ] Performance test - [ ] N/A Affects: - [ ] Documentation affected (Please add the label if documentation needs to be modified.) - [ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.） - [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).) - [ ] Performance impacted: Consumes more CPU/Memory ## Release notes: Please confirm whether to be reflected in release notes and how to describe: > ex. Fixed the bug ..... Migrated from vesoft-inc#5345 Co-authored-by: Milittle <mizeshuang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve int convert float/doulbe/bool, bool convert int, float/double convert int.