fix error for checkpoint when space doesn't exist in storageNode. #2287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darionyaphet
previously approved these changes
Aug 13, 2020
| std::unique_ptr<kvstore::KVIterator> iter; | ||
| auto kvRet = kv_->prefix(kDefaultSpaceId, kDefaultPartId, prefix, &iter); | ||
| if (kvRet != kvstore::ResultCode::SUCCEEDED) { | ||
| return {}; |
There was a problem hiding this comment.
maybe it is an error ?
There was a problem hiding this comment.
em... What's the difference between '{}' and 'empty list'?
There was a problem hiding this comment.
maybe it is an error ?
I see what you mean. let me fix it.
|
Please hold this PR. |
Any concerns? |
By @darionyaphet's comment . An invalid checkpoint will be created when kv_->prefix error occur. |
bright-starry-sky
dismissed stale reviews from darionyaphet and dangleptr
via
617fb24
|
Addressed darionyaphet's comment. |
dangleptr
approved these changes
Aug 14, 2020
xuguruogu
pushed a commit
to xuguruogu/nebula
that referenced
this pull request
Sep 12, 2020
…soft-inc#2287) * fix error for checkpoint * fix error for checkpoint * Addressed darionyaphet's comment Co-authored-by: dangleptr <37216992+dangleptr@users.noreply.github.com>
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
…soft-inc#2287) * fix error for checkpoint * fix error for checkpoint * Addressed darionyaphet's comment Co-authored-by: dangleptr <37216992+dangleptr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.