Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raft lease is always valid when replica is one #2276

Merged
merged 2 commits into from
Aug 6, 2020
Merged

raft lease is always valid when replica is one #2276

merged 2 commits into from
Aug 6, 2020

Conversation

panda-sheep
Copy link
Contributor

Synchronize storage 2.0 pr 69

dangleptr
dangleptr reviewed Aug 6, 2020
View reviewed changes
Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Thanks for taking care of it.

@xuguruogu
Copy link
Collaborator

So, may be cannot accessed when replica set is 1

@dangleptr
Copy link
Contributor

So, may be cannot accessed when replica set is 1

Sorry? I can't follow you. If replica is 1, the leader will always be leader.

@xuguruogu
Copy link
Collaborator

So, may be cannot accessed when replica set is 1

Sorry? I can't follow you. If replica is 1, the leader will always be leader.

I encountered a bug before, request may be rejected under 1 replica set num, with the error of change leader.

@panda-sheep panda-sheep added the ready-for-testing PR: ready for the CI test label Aug 6, 2020
@dangleptr dangleptr merged commit 6405167 into vesoft-inc:master Aug 6, 2020
@panda-sheep panda-sheep deleted the raft_lease_in_one_replica branch August 6, 2020 12:28
xuguruogu pushed a commit to xuguruogu/nebula that referenced this pull request Sep 12, 2020
@panda-sheep @dangleptr @xuguruogu
raft lease is always valid when replica is one Synchronize storage 2.…
316e5d2 
…0 pr 69 (vesoft-inc#2276)

Co-authored-by: dangleptr <37216992+dangleptr@users.noreply.github.com>
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@panda-sheep @dangleptr
raft lease is always valid when replica is one Synchronize storage 2.…
cb60242 
…0 pr 69 (vesoft-inc#2276)

Co-authored-by: dangleptr <37216992+dangleptr@users.noreply.github.com>
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
@nebula-bots @liwenhui-soul
Revert "do not check term for leader info by default para" (vesoft-in…
f13a4b9 
…c#2276)

This reverts commit 593bffc.

Co-authored-by: liwenhui-soul <38217397+liwenhui-soul@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangleptr dangleptr dangleptr approved these changes

@liuyu85cn liuyu85cn liuyu85cn approved these changes

@critical27 critical27 Awaiting requested review from critical27 critical27 is a code owner

@bright-starry-sky bright-starry-sky Awaiting requested review from bright-starry-sky

@darionyaphet darionyaphet Awaiting requested review from darionyaphet

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panda-sheep @xuguruogu @dangleptr @liuyu85cn