Correc the alter default value dont't affected. #2003
Conversation
Shylock-Hg
requested review from
darionyaphet,
laura-ding,
bright-starry-sky,
CPWstatic,
critical27,
dangleptr and
dutor
|
TODO: Add cases to https://github.com/vesoft-inc-private/nebula-test |
Codecov Report
@@ Coverage Diff @@
## master #2003 +/- ##
==========================================
- Coverage 86.80% 86.73% -0.07%
==========================================
Files 641 641
Lines 61369 61731 +362
==========================================
+ Hits 53272 53545 +273
- Misses 8097 8186 +89
Continue to review full report at Codecov.
|
| if (value->getType() != nebula::cpp2::Value::Type::timestamp) { | ||
| LOG(ERROR) << "Create Tag Failed: " << name | ||
| << " type mismatch"; | ||
| return cpp2::ErrorCode::E_CONFLICT; |
There was a problem hiding this comment.
Follow the previous.
There was a problem hiding this comment.
Previous may be an error, this data type or parameter is wrong
There was a problem hiding this comment.
Follow the behavior that create the tag/edge.
| auto name = col.get_name(); | ||
| auto dKey = MetaServiceUtils::defaultKey(spaceId, Id, name); | ||
| std::string defaultValue; | ||
| if (col.__isset.default_value) { |
There was a problem hiding this comment.
Here can encapsulate as a function, and where need it, call it, don't need judge twice.
There was a problem hiding this comment.
The default will be refactor in #2011
| LOG(INFO) << "Alter edge " << req.get_edge_name() << ", edgeType " << edgeType; | ||
| data.emplace_back(MetaServiceUtils::schemaEdgeKey(spaceId, edgeType, version), | ||
| MetaServiceUtils::schemaEdgeVal(req.get_edge_name(), schema)); | ||
| resp_.set_id(to(edgeType, EntryType::EDGE)); | ||
| // Now we get default value from meta instead of cache |
There was a problem hiding this comment.
Is the annotation wrong?
There was a problem hiding this comment.
Don't, graph get it from meta directly now, I had a PR #2011 to fix it.
| LOG(INFO) << "Alter Tag " << req.get_tag_name() << ", tagId " << tagId; | ||
| data.emplace_back(MetaServiceUtils::schemaTagKey(spaceId, tagId, version), | ||
| MetaServiceUtils::schemaTagVal(req.get_tag_name(), schema)); | ||
| resp_.set_id(to(tagId, EntryType::TAG)); | ||
| // Now we get default value from meta instead of cache |
Codecov Report
@@ Coverage Diff @@
## master #2003 +/- ##
==========================================
- Coverage 86.84% 86.74% -0.10%
==========================================
Files 641 641
Lines 61651 61830 +179
==========================================
+ Hits 53541 53636 +95
- Misses 8110 8194 +84
Continue to review full report at Codecov.
|
* Correc the alter default value dont't affected. * Treat bitint as unkown error. * Fix one alignment. * Correct the error message. * Fix one alignment. * Fix one alignment. * Fix one alignment. * Correct the default value remove logical. * Return error when unknown type. * Fix one code alignment. * Remove the useless code. * Update to master. * Merge the default value handle code. Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
…oft-inc#2003) Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
What changes were proposed in this pull request?
Close #1987
Why are the changes needed?
Does this PR introduce any user-facing change?
NO
How was this patch tested?