Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc]show statements #1924

Merged
merged 3 commits into from
Mar 25, 2020
Merged

[doc]show statements #1924

merged 3 commits into from
Mar 25, 2020

Conversation

amber-moe
Copy link
Contributor

What changes were proposed in this pull request?

Reorganized show statements doc.

@amber-moe amber-moe mentioned this pull request Mar 16, 2020
Closed
panda-sheep
panda-sheep reviewed Mar 16, 2020
View reviewed changes
...uery-language/4.statement-syntax/3.utility-statements/show-statements/show-charset-syntax.md
========================================================
| utf8 | UTF-8 Unicode | utf8_bin | 4 |
--------------------------------------------------------
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The results ofshow charset and show collation is incomplete.
when pr 1782 merged, you need update it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your kind remind

whitewum
whitewum previously approved these changes Mar 16, 2020
View reviewed changes
panda-sheep
panda-sheep reviewed Mar 20, 2020
View reviewed changes
...ry-language/4.statement-syntax/3.utility-statements/show-statements/show-collation-syntax.md Show resolved Hide resolved
...uery-language/4.statement-syntax/3.utility-statements/show-statements/show-charset-syntax.md
```

`SHOW CHARSET` 返回所有可用的字符集。目前支持两种类型：utf8、utf8mb4。其中默认字符集为 utf8。**Nebula Graph** 将 utf8 进行了扩展，utf8 同时支持 4 个字节的字符，因此，utf8 和 utf8mb4 是等价的。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHOW CHARSET 语句列出Nebula Graph 目前支持的所有字符集。目前支持两种字符集：

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok here.

@panda-sheep
Copy link
Contributor

The part of charset and collation is ok.

bright-starry-sky
bright-starry-sky approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@bright-starry-sky bright-starry-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM，need other reviewer to take a look.

@amber-moe amber-moe added the ready-for-testing PR: ready for the CI test label Mar 24, 2020
@dangleptr dangleptr merged commit 7b26043 into vesoft-inc:master Mar 25, 2020
@amber-moe amber-moe deleted the show-statements branch March 26, 2020 01:47
dangleptr added a commit that referenced this pull request Apr 1, 2020
@jude-zhu @dangleptr
@JaySon-Huang @amber-moe @Shylock-Hg @monadbobo @dutor @bright-starry-sky @Liuxue-Yang @laura-ding @critical27 @panda-sheep @liuyu85cn
RC4 rebase master (#2034)
2ea95f3 
* Upgrade rocksdb to 6.7.3 (#1948)

Co-authored-by: heng <heng.chen@vesoft.com>
Co-authored-by: yaphet <darion.wang@vesoft.com>

* Detect OS type and exit if not built in Linux (#1951)

* Detect OS type and exit if not built in Linux

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

* Disable for FreeBSD

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

* [doc] user-permission-mng (#1929)

* alter user & change psw

* built in roles

* cbs comments

* fix comments

* update table

* addenable_authorize doc

* [doc] ttl doc modification (#1939)

* ttl doc modification

* fix comments

* yt comments

* silver days comments

* timestamp update

* Let action not fail fast. (#1909)

* Let action not fail fast.

* Disable the ci will product artifact.

* Remove removePrefix interface in kvstore (#1953)

Co-authored-by: heng <heng.chen@vesoft.com>
Co-authored-by: yaphet <darion.wang@vesoft.com>

* using admin client in MetaServiceHandler (#1864)

* [doc] fix typo (#1954)

* [doc]show statements (#1924)

* [doc]customized dir (#1906)

* Fixed a bug caused by not filtering the versions of edges (#1962)

* Fixed a bug caused by not filtering the versions of edges when executing "go from vid over *".

* address CPWstatic's comment.

* Modify the listEdges interface and add parameters to directly return all latest versions of edges.

* address laura's comment.

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>

* [doc]modify job manger doc (#1957)

* modify job manger doc

* add flush

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>

* Fix delete verticse (#1970)

* Fix the read performance issue after delete range with rocksdb-5.15.10 (#1973)

* Fix the read performace issue after delete range with rocksdb-5.15.10

* Fix the move issue

* fix the move issue

* Rebase and address bright-starry-sky's comments

Co-authored-by: heng <heng.chen@vesoft.com>

* Remove the LOG(FATAL) when encounting the unknown log type (#1978)

* 1,Improve customer friendliness; 2, fixed typo error (#1980)

* upgrade spark download address (#1981)

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>

* fix-typo-in-doc (#1976)

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>

* modify commands in build doc (#1969)

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>

* modify log level (#1945)

Co-authored-by: dangleptr <37216992+dangleptr@users.noreply.github.com>
Co-authored-by: dutor <440396+dutor@users.noreply.github.com>

* use bloom filter, add event listener to collect stats of compaction, improve update rocksdb options (#1959)

* open bloom filter in default conf, add event listener to collect stats of compaction

* imporve update rocksdb configs

* fix ut error

Co-authored-by: yaphet <darion.wang@vesoft.com>

* Update the interface atomicOp to support empty string (#2002)

Co-authored-by: heng <heng.chen@vesoft.com>
Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>

* update to rc4 (#1968)

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>

* Fixed if you execute "go from xx over *", and when there is no edge under a space, (#1983)

an unreasonable error message is returned (SpaceId `xxx 'is nonexistent)

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>

* [doc]pr-commit-msg (#1993)

* pr-commit-msg

* add examples

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>

* doc:modify ttl query (#2006)

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>

* Let merge coverage report faster by fastcov instead of lcov. (#1943)

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>

* Auto check keyword (#1922)

* Supports the detection keyword, name_label supports string

* add tests

* address Shylock's comment

* modify  to add reserved keyword

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>

* Fix coredump for update if encountering bad format row (#2024)

Co-authored-by: heng <heng.chen@vesoft.com>
Co-authored-by: bright-starry-sky <56461666+bright-starry-sky@users.noreply.github.com>

* fixed loop depend problem for compile link (#1995)

* fixed loop depend problem

* fixed error for clang9 and gcc9

* Addressed laura-ding's comment

* Check all reader is null or not before using it (#2029)

* fix go without yield return errror result (#2012)

* fix go without yield return errror result

* fix format

* address dangleptr's comment

* address issue change TTL_DURATION not negative

* add onlyStructure is true test case

Co-authored-by: bright-starry-sky <56461666+bright-starry-sky@users.noreply.github.com>

* fixed bug for delete vertex without edge (#2001)

* When deleting a vertex, if the edge does not exist,
then we should continue to delete the vertex instead of reporting an error.

* added the testcase for delete vertex without edge.

* add alias for lookup (#2000)

* fix bug 1990/1991 (#2007)

* 1. meta client sub mit job only to leader 2. sort jobs in desc id order

* now show jobs return in desc order, adjust UT

Co-authored-by: dangleptr <37216992+dangleptr@users.noreply.github.com>

* upload package to oss (#1972)

* upload oss

* update

* Remove redundant

* address @yixinlu's comment

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>

Co-authored-by: dangleptr <37216992+dangleptr@users.noreply.github.com>
Co-authored-by: heng <heng.chen@vesoft.com>
Co-authored-by: yaphet <darion.wang@vesoft.com>
Co-authored-by: JaySon <jayson.hjs@gmail.com>
Co-authored-by: Amber Zhang <42762957+Amber1990Zhang@users.noreply.github.com>
Co-authored-by: Shylock Hg <33566796+Shylock-Hg@users.noreply.github.com>
Co-authored-by: Simon Liu <331435+monadbobo@users.noreply.github.com>
Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
Co-authored-by: bright-starry-sky <56461666+bright-starry-sky@users.noreply.github.com>
Co-authored-by: Liuxue-Yang <50105172+Liuxue-Yang@users.noreply.github.com>
Co-authored-by: laura-ding <48548375+laura-ding@users.noreply.github.com>
Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Co-authored-by: panda-sheep <59197347+panda-sheep@users.noreply.github.com>
Co-authored-by: liuyu85cn <52276794+liuyu85cn@users.noreply.github.com>
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@amber-moe
[doc]show statements (vesoft-inc#1924)
261feda
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
@liwenhui-soul @Sophie-Xie
check current term when start to receive checkpoint (vesoft-inc#1924)
e97896d 
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panda-sheep panda-sheep panda-sheep left review comments

@laura-ding laura-ding laura-ding left review comments

@bright-starry-sky bright-starry-sky bright-starry-sky approved these changes

@whitewum whitewum whitewum approved these changes

@dutor dutor Awaiting requested review from dutor

@liuyu85cn liuyu85cn Awaiting requested review from liuyu85cn

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amber-moe @panda-sheep @laura-ding @whitewum @bright-starry-sky @dangleptr