Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added if_exists flag when drop index of edge and tag #1598

Merged
merged 15 commits into from
Jan 8, 2020
Merged

Added if_exists flag when drop index of edge and tag #1598

merged 15 commits into from
Jan 8, 2020

Conversation

wfystx
Copy link
Contributor

@wfystx wfystx commented Jan 7, 2020

No description provided.

@wfystx wfystx requested a review from darionyaphet January 7, 2020 06:26
@darionyaphet
Copy link
Contributor

LGTM

@darionyaphet darionyaphet added the ready-for-testing PR: ready for the CI test label Jan 7, 2020
@darionyaphet
Copy link
Contributor

jenkins go

@amber-moe amber-moe mentioned this pull request Jan 7, 2020
Merged
@nebula-community-bot
Copy link
Member

Unit testing failed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@wfystx wfystx requested a review from critical27 January 7, 2020 09:56
critical27
critical27 approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nebula-community-bot
Copy link
Member

Unit testing passed.

dutor
dutor approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dutor dutor merged commit c738686 into vesoft-inc:master Jan 8, 2020
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@wfystx @dutor
Added if_exists flag when drop index of edge and tag (vesoft-inc#1598)
80073f3 
* Added if_exists check when drop the structures of index

* Added test cases

* Added test cases

* Formatted processor files

* Formatted processor files

* modifed return type of drop index to bool

* slightly modifed testcase

* slightly modifed testcase

* corrected log

Co-authored-by: yaphet <darion.wang@vesoft.com>
Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amber-moe amber-moe amber-moe left review comments

@dutor dutor dutor approved these changes

@darionyaphet darionyaphet darionyaphet approved these changes

@critical27 critical27 critical27 approved these changes

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wfystx @darionyaphet @nebula-community-bot @dutor @critical27 @amber-moe