Enhance Spark Writer #1512
Merged
Enhance Spark Writer #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darionyaphet
requested review from
dutor,
CPWstatic,
critical27,
dangleptr,
jude-zhu and
bright-starry-sky
Conflicts: src/tools/spark-sstfile-generator/pom.xml src/tools/spark-sstfile-generator/src/main/scala/com/vesoft/nebula/tools/generator/v2/SparkClientGenerator.scala
darionyaphet
added
ready-for-testing
|
Unit testing passed. |
darionyaphet
changed the title
|
Unit testing passed. |
amber-moe
reviewed
Jan 6, 2020
...ile-generator/src/main/scala/com/vesoft/nebula/tools/generator/v2/SparkClientGenerator.scala
Outdated
Show resolved
Hide resolved
|
Unit testing passed. |
…into spark-config Conflicts: src/tools/spark-sstfile-generator/src/main/resources/application.conf src/tools/spark-sstfile-generator/src/main/scala/com/vesoft/nebula/tools/generator/v2/SparkClientGenerator.scala
|
TODO : I will update the document later :D |
critical27
reviewed
Jan 10, 2020
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| <groupId>com.vesoft</groupId> | |||
| <artifactId>nebula-utils</artifactId> | |||
| <version>1.0.0-rc2</version> | |||
| <version>1.0.0-rc3</version> | |||
There was a problem hiding this comment.
Have we uploaded rc3 version jni? rc2 is ok I guess
There was a problem hiding this comment.
I understand that RC3 will release later so I update this version number.
Actually, when RC2 release we should update this version.
There was a problem hiding this comment.
Ok, remember to upload it to mvn
critical27
approved these changes
Jan 14, 2020
dangleptr
approved these changes
Jan 14, 2020
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* change config to list * change config to list Co-authored-by: dangleptr <37216992+dangleptr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are using schema name for the config's key. But actually some user will loading data into the same schema from different data source. So I have modified the config's structure to support it.
Support error log save into separated HDFS file and reload.
Support rate limit in spark writer