Fix default value bug #1452
Merged
Fix default value bug #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit testing passed. |
src/graph/InsertVertexExecutor.cpp
Outdated
| @@ -48,14 +48,14 @@ Status InsertVertexExecutor::check() { | |||
| auto *tagName = item->tagName(); | |||
| auto tagStatus = ectx()->schemaManager()->toTagID(spaceId_, *tagName); | |||
| if (!tagStatus.ok()) { | |||
| LOG(ERROR) << "No schema found for " << tagName; | |||
| LOG(ERROR) << "No schema found for " << *tagName; | |||
|
Unit testing passed. |
| @@ -46,6 +46,36 @@ TEST_F(SchemaTest, TestComment) { | |||
| } | |||
| } | |||
|
|
|||
| TEST_F(SchemaTest, TestDefaultValue) { | |||
| auto client = gEnv->getClient(); | |||
There was a problem hiding this comment.
have a test case about default value ?
There was a problem hiding this comment.
data_test include it
| std::string cmd = "CREATE TAG default_tag(name string DEFAULT \"\", " | ||
| "age int DEFAULT \"10\")"; | ||
| auto code = client->execute(cmd, resp); | ||
| ASSERT_EQ(cpp2::ErrorCode::E_EXECUTION_ERROR, code); |
There was a problem hiding this comment.
duplicate with previous
There was a problem hiding this comment.
the previous the first params without a default value, but this has
darionyaphet
approved these changes
Dec 25, 2019
|
Unit testing passed. |
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* Fixed default value related bug * Check unknown column * Fix ut failed Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
* forbid insert vertex when vertex_key flag is off * fix issue ent#1420 * fix test case * fix format Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
colse #1421, close #1368