Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance in the LDBC scenarios. #4122

Closed
1 task
CPWstatic opened this issue Apr 8, 2022 · 1 comment
Closed
1 task

Improve performance in the LDBC scenarios. #4122

CPWstatic opened this issue Apr 8, 2022 · 1 comment
Assignees
@yixinglu @nevermore3 @jinyingsunny
Labels
type/enhancement Type: make the code neat or more efficient
Milestone
v3.5.0

Comments

@CPWstatic
Copy link
Contributor

CPWstatic commented Apr 8, 2022 •
edited by linview
Loading

Introduction
Improve performance in the LDBC scenarios.

Contents
There are several measures to improve performance, we will have a doc.

Related work
@CPWstatic CPWstatic added the type/enhancement Type: make the code neat or more efficient label Apr 8, 2022
@CPWstatic CPWstatic changed the title LDBC. Improve performance in the LDBC scenarios. Apr 8, 2022
@Sophie-Xie Sophie-Xie moved this from Todo to Backlog in Nebula Graph v3.2.0 and Tools Apr 8, 2022
@Sophie-Xie Sophie-Xie added this to the v3.2.0 milestone Apr 8, 2022
@jamieliu1023 jamieliu1023 mentioned this issue Apr 9, 2022
Closed
@Sophie-Xie Sophie-Xie mentioned this issue Apr 12, 2022
Closed
This was referenced Apr 18, 2022
Closed
Closed
Closed
Closed
@Sophie-Xie Sophie-Xie moved this from Backlog to Designing in Nebula Graph v3.2.0 and Tools Apr 21, 2022
@Sophie-Xie Sophie-Xie moved this from Designing to Coding in Nebula Graph v3.2.0 and Tools Apr 22, 2022
This was referenced May 9, 2022
Merged
Merged
This was referenced May 16, 2022
Merged
Closed
@Sophie-Xie Sophie-Xie moved this from Coding to Testing in Nebula Graph v3.2.0 and Tools Jul 1, 2022
@Sophie-Xie Sophie-Xie modified the milestones: v3.2.0, v3.3.0 Jul 4, 2022
@Sophie-Xie Sophie-Xie assigned nevermore3 and unassigned CPWstatic and Shylock-Hg Jul 19, 2022
@Sophie-Xie Sophie-Xie moved this from Testing to Done in Nebula Graph v3.2.0 and Tools Jul 19, 2022
@Sophie-Xie Sophie-Xie moved this from Backlog to Designing in NebulaGraph v3.3.0 and Tools Aug 1, 2022
@Sophie-Xie Sophie-Xie moved this from Designing to Coding in NebulaGraph v3.3.0 and Tools Aug 1, 2022
@Sophie-Xie Sophie-Xie moved this from Coding to Designing in NebulaGraph v3.3.0 and Tools Sep 9, 2022
@Sophie-Xie Sophie-Xie moved this from Designing to Coding in NebulaGraph v3.3.0 and Tools Sep 16, 2022
@Sophie-Xie Sophie-Xie moved this from Todo to Backlog in NebulaGraph v3.4.0 and Tools Oct 12, 2022
@Sophie-Xie Sophie-Xie modified the milestones: v3.3.0, v3.4.0 Nov 4, 2022
@Sophie-Xie Sophie-Xie moved this from Backlog to Coding in NebulaGraph v3.4.0 and Tools Dec 15, 2022
@Sophie-Xie Sophie-Xie modified the milestones: v3.4.0, v3.5.0 Jan 29, 2023
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Jan 31, 2023
@nebula-bots @Shylock-Hg
Eliminate vid predication Filter. (vesoft-inc#870)
50425ea 
<!--
Thanks for your contribution!
In order to review PR more efficiently, please add information according to the template.
-->

## What type of PR is this?
- [ ] bug
- [ ] feature
- [x] enhancement

## What problem(s) does this PR solve?
#### Issue(s) number: 
Sub job of vesoft-inc#4122 

#### Description:
GetVertices will retrieve Vertex by Id set directly, so we don't filter them again in Filter operator, so we eliminate this Filter operator.

## How do you solve it?



## Special notes for your reviewer, ex. impact of this fix, design document, etc:



## Checklist:
Tests:
- [ ] Unit test(positive and negative cases)
- [ ] Function test
- [ ] Performance test
- [ ] N/A

Affects:
- [ ] Documentation affected (Please add the label if documentation needs to be modified.)
- [ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.）
- [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
- [ ] Performance impacted: Consumes more CPU/Memory


## Release notes:

Please confirm whether to be reflected in release notes and how to describe:
> ex. Fixed the bug .....


Migrated from vesoft-inc#4249

Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com>
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Jan 31, 2023
@nebula-bots @Shylock-Hg
Push vFilter down. (vesoft-inc#917)
b425cf9 
<!--
Thanks for your contribution!
In order to review PR more efficiently, please add information according to the template.
-->

## What type of PR is this?
- [ ] bug
- [ ] feature
- [x] enhancement

## What problem(s) does this PR solve?
#### Issue(s) number: 
Sub job of vesoft-inc#4122 

#### Description:


## How do you solve it?



## Special notes for your reviewer, ex. impact of this fix, design document, etc:



## Checklist:
Tests:
- [ ] Unit test(positive and negative cases)
- [ ] Function test
- [ ] Performance test
- [ ] N/A

Affects:
- [ ] Documentation affected (Please add the label if documentation needs to be modified.)
- [ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.）
- [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
- [ ] Performance impacted: Consumes more CPU/Memory


## Release notes:

Please confirm whether to be reflected in release notes and how to describe:
> ex. Fixed the bug .....


Migrated from vesoft-inc#4260

Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com>
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Jan 31, 2023
@nebula-bots @Shylock-Hg
Feature/arena allocator (vesoft-inc#921)
fc4e142 
<!--
Thanks for your contribution!
In order to review PR more efficiently, please add information according to the template.
-->

## What type of PR is this?
- [ ] bug
- [ ] feature
- [x] enhancement

## What problem(s) does this PR solve?
#### Issue(s) number: 

#### Description:
Sub job of vesoft-inc#4122

## How do you solve it?



## Special notes for your reviewer, ex. impact of this fix, design document, etc:



## Checklist:
Tests:
- [ ] Unit test(positive and negative cases)
- [ ] Function test
- [ ] Performance test
- [ ] N/A

Affects:
- [ ] Documentation affected (Please add the label if documentation needs to be modified.)
- [ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.）
- [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
- [ ] Performance impacted: Consumes more CPU/Memory


## Release notes:

Please confirm whether to be reflected in release notes and how to describe:
> ex. Fixed the bug .....


Migrated from vesoft-inc#4239

Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com>
@xtcyclist
Copy link
Contributor

Shall we close this issue?

@wey-gu wey-gu mentioned this issue Apr 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yixinglu yixinglu

@nevermore3 nevermore3

@jinyingsunny jinyingsunny

Labels
type/enhancement Type: make the code neat or more efficient
Projects
No open projects
Nebula Graph v3.2.0 and Tools
Status: Done
Milestone
v3.5.0
Development

No branches or pull requests
7 participants
@yixinglu @nevermore3 @xtcyclist @CPWstatic @Shylock-Hg @Sophie-Xie @jinyingsunny