-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
supplementary code comments about Raft leaderElection #2380
Comments
ystaticy
pushed a commit
to ystaticy/nebula
that referenced
this issue
Oct 27, 2020
ystaticy
pushed a commit
to ystaticy/nebula
that referenced
this issue
Oct 27, 2020
Well done. Do you want to give a pr for it. Thanks |
How's it going? |
I'll close it firstly. Please feel free to reopen it if you still have interest in it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
in leaderElection,there is a code comments about Leader A crashed and B,C will begin the election.
the sentence 'Meanwhile C begin the election' .It means there is a situation where C restarts the election after B win.
In fact, there is one condition for C to resume the election after B win.
that is, the heartbeat between B and C has timed out due to pressure and other reasons.
so I will add the describe to the code comments.
The text was updated successfully, but these errors were encountered: