Skip to content

Commit

Permalink
amend comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
xtcyclist committed Dec 15, 2022
1 parent ad9c822 commit 616b7f1
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/common/expression/AttributeExpression.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,8 @@ const Value &AttributeExpression::eval(ExpressionContext &ctx) {
return lvalue.getMap().at(rvalue.getStr());
case Value::Type::VERTEX: {
/*
* WARNING(Xuntao): this entire case shall be removed, in theory.
* Vertices shall not be evaluated as AttributeExpressions, since
* there shall always be a tag specified in the format of:
* WARNING(Xuntao): Vertices shall not be evaluated as AttributeExpressions,
* since there shall always be a tag specified in the format of:
* var.tag.property. Due to design flaws, however, we have to keep
* this case segment.
*/
Expand All @@ -35,7 +34,7 @@ const Value &AttributeExpression::eval(ExpressionContext &ctx) {
return result_;
}
/*
* WARNING(Xuntao): the following code snippet is a dedicated to address the legacy
* WARNING(Xuntao): the following code snippet is dedicated to address the legacy
* problem of treating LabelTagProperty expressions as Attribute expressions.
* This snippet is necessary to allow users to write var.tag.prop in
* ListComprehensionExpression without making structural changes to the implementation.
Expand Down

0 comments on commit 616b7f1

Please sign in to comment.