This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
darionyaphet,
sherman-the-tank,
liuyu85cn,
bright-starry-sky,
panda-sheep and
dangleptr
and removed request for
sherman-the-tank
August 5, 2020 07:52
panda-sheep
reviewed
Aug 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me
panda-sheep
reviewed
Aug 5, 2020
panda-sheep
reviewed
Aug 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
panda-sheep
previously approved these changes
Aug 6, 2020
redundant diff file. |
Good catch, thx. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better to review by each commit, some modification is scattered among lots of files.
Some major improvement:
FilterNode
andAggregateNode
if necessary.RowReader
from stack instead of heap, similar to fix VertexHolder::getDefaultProp performance issue. nebula#2249. The difference is that we useRowReaderWrapper
to wrap reader of v1 and v2.The Benchmark will retrieve 1 tag and 1000 edges, almost the same as vesoft-inc/nebula#2270, as follows:
GetNeighbors
, one vertex, no filter.GetNeighbors
, one vertex, with filter.filter_ratio
could modify the ratio of edges which could pass the filter.After these tuning, the benchmark of 2.0 has ~20% improvement than 1.0.