-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support path in nGQL, optimized nGQL edge reader #133
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2dc0e5c
feat: support path in nGQL, not raise exception for other types
wey-gu f8bbabc
fix typing and error handling as commented
wey-gu 7c7f74b
handle List Value typing
wey-gu 224688d
wording of the exception and logging
wey-gu 723212d
fix typing, added test for ngql
wey-gu d8d7703
test: add GET SUBGRAPH and FIND PATH
wey-gu e2b05b8
fix ngql example and test cases
wey-gu 3365bdf
fix typo in withConnectionRetry
wey-gu c354e65
Merge branch 'master' into ngql_reader
wey-gu 1324c80
add back withConnectionRetry in ngql tests
wey-gu 1d9735a
fix missing operateType
wey-gu 548511e
fix null pointer
wey-gu 04090c8
test: add with prop for prop reading
wey-gu e4b6ef5
docs: update examples for with prop clause
wey-gu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Connector is an API not a tool, why just skip but not throw exception?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense, was doing so due to some of the users are not familiar, or experienced enough to inspect error logs properly.
Will bring back the exception.
But we may need to handle NULL/Empty properly in such cases.