-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the protocol with header protocol #254
Conversation
Codecov ReportBase: 77.45% // Head: 77.61% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #254 +/- ##
==========================================
+ Coverage 77.45% 77.61% +0.16%
==========================================
Files 18 18
Lines 2408 2408
==========================================
+ Hits 1865 1869 +4
+ Misses 543 539 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
is this related to vesoft-inc/nebula#5190 or other issues actually? |
My bad, I've updated the issue link vesoft-inc/nebula#5191 |
Thanks! So with header protocol, the client will not hang but exit in such huge-sized frame cases, right? |
Correct, an exception indicating the frame size is too large will be thrown. |
storage client also needs consideration. |
4a2a2b9
to
97acc41
Compare
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Address vesoft-inc/nebula#5191
Description:
Replace the protocol with header protocol
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: