Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add requirements.txt #106

Merged
merged 4 commits into from
May 20, 2021
Merged

Add requirements.txt #106

merged 4 commits into from
May 20, 2021

Conversation

yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented May 19, 2021 •
edited by laura-ding
Loading

Some test failed I don't know why.
e.g.
https://github.com/yihong0618/nebula-python/actions/runs/855718226

close #105

@yihong0618
Copy link
Contributor Author

#104

laura-ding
laura-ding reviewed May 19, 2021
View reviewed changes
README.md Outdated
@@ -60,6 +60,15 @@ When your environment cannot access `pypi`, you need to install the following pa
- httplib2
- futures # python2.x is needed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 57-61 can be deleted, directly to use requirements.txt is ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@laura-ding
Copy link
Contributor

Some test failed I don't know why.
e.g.
https://github.com/yihong0618/nebula-python/actions/runs/855718226

Maybe the errorcode change of server, i need to update the thrift file

@yihong0618
Copy link
Contributor Author

Some test failed I don't know why.
e.g.
https://github.com/yihong0618/nebula-python/actions/runs/855718226

Maybe the errorcode change of server, i need to update the thrift file

Got it

@yihong0618
Copy link
Contributor Author

Some test failed I don't know why.
e.g.
https://github.com/yihong0618/nebula-python/actions/runs/855718226

Maybe the errorcode change of server, i need to update the thrift file

FYI

Its strange that 3.7 passed sometimes 3.6 failed

image

@laura-ding
Copy link
Contributor

Some test failed I don't know why.
e.g.
https://github.com/yihong0618/nebula-python/actions/runs/855718226

Maybe the errorcode change of server, i need to update the thrift file

FYI

Its strange that 3.7 passed sometimes 3.6 failed

image

because the leader of metad is changed. The randomly selected Meta happens to be the leader, so it succeeds

laura-ding
laura-ding approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@laura-ding laura-ding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@laura-ding laura-ding changed the title feat for #105 Add requirements.txt May 20, 2021
@laura-ding laura-ding merged commit e3e6e7a into vesoft-inc:master May 20, 2021
@yihong0618 yihong0618 mentioned this pull request Mar 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laura-ding laura-ding laura-ding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] add requirements.txt and cache the pip requirements in Actions
2 participants
@yihong0618 @laura-ding