feat: add resources e2e #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veezhang
reviewed
Oct 13, 2023
| return validator.New().Var(val, string(r)) | ||
| } | ||
|
|
||
| type Resource corev1.ResourceRequirements |
There was a problem hiding this comment.
Perhaps the definition could be more abstract rather than specific to a certain type.
| @@ -110,6 +113,24 @@ func defaultNebulaClusterReadyFuncForStatus(_ context.Context, _ *envconf.Config | |||
| ) | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This func is used to cmp nc status, maybe put those in defaultNebulaClusterReadyFuncForGraphd/Metad/Storaged is more suitable.
| }, | ||
| } | ||
|
|
||
| if err := cfg.Client().Resources().Get(ctx, sts.Name, sts.Namespace, sts); err != nil { |
There was a problem hiding this comment.
We have already obtained it, why not check more fields, such as version, replicas , etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
make e2e E2EARGS="--kubeconfig ~/.kube/config -labels category=basic,group=resources"
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: