Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support to config the version white list #571

Merged
merged 3 commits into from
Dec 25, 2023

Conversation

Nicole00
Copy link
Contributor

@Nicole00 Nicole00 commented Dec 22, 2023

close #567
close #568
close #569

the new config for version is optional, there is no confluence for old users.

For users who need to config a special version, the usage is:

NebulaPool:

NebulaPoolConfig nebulaPoolConfig = new NebulaPoolConfig();
nebulaPoolConfig.setVersion("test");

SessionPool:

SessionPoolConfig sessionPoolConfig =new SessionPoolConfig(addresses, spaceName, user, password)
                        .setVersion("test");

MetaClient:

 MetaClient client = new MetaClient(address, port);
 client.setVersion("test");

StorageClient:

StorageClient storageClient = new StorageClient(address);
storageClient.setVersion("test");

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (86d4a76) 62.85% compared to head (85c5f10) 63.03%.

Files Patch % Lines
...ava/com/vesoft/nebula/client/meta/MetaManager.java 50.00% 6 Missing ⚠️
...vesoft/nebula/client/graph/net/SyncConnection.java 64.28% 4 Missing and 1 partial ⚠️
...va/com/vesoft/nebula/client/graph/SessionPool.java 50.00% 2 Missing ⚠️
.../vesoft/nebula/client/graph/SessionPoolConfig.java 50.00% 2 Missing ⚠️
...ebula/client/graph/net/RoundRobinLoadBalancer.java 75.00% 2 Missing ⚠️
...com/vesoft/nebula/client/graph/net/NebulaPool.java 90.90% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #571      +/-   ##
============================================
+ Coverage     62.85%   63.03%   +0.18%     
- Complexity      801      807       +6     
============================================
  Files            72       72              
  Lines          3963     4004      +41     
  Branches        539      542       +3     
============================================
+ Hits           2491     2524      +33     
- Misses         1098     1106       +8     
  Partials        374      374              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nicole00 Nicole00 merged commit 138707e into vesoft-inc:master Dec 25, 2023
2 checks passed
Nicole00 added a commit to Nicole00/nebula-java that referenced this pull request Dec 25, 2023
* support to config the version white list

* support to config the version white list for MetaClient

* support to config the version white list for StorageClient
@Nicole00 Nicole00 deleted the version_write_list branch January 12, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants