Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement:Support more type value as parameter #461

Closed
wants to merge 0 commits into from

Conversation

CorvusYe
Copy link
Contributor

@CorvusYe CorvusYe commented Jul 4, 2022

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 4, 2022

CLA assistant check
All committers have signed the CLA.

@wey-gu wey-gu requested a review from Aiee July 6, 2022 09:20
Copy link
Contributor

@czpmango czpmango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wey-gu
Copy link
Contributor

wey-gu commented Feb 23, 2023

@Nicole00 @CorvusYe could we move this PR on?

@CorvusYe
Copy link
Contributor Author

@wey-gu
There are some conflicts.
I will resolve tomorrow, if it is still helpful in this version.

put(Value.class, (Setter<Value>) (param) -> param );
put(boolean.class, (Setter<Boolean>) Value::bVal);
put(Boolean.class, (Setter<Boolean>) Value::bVal);
put(int.class, (Setter<Integer>) Value::iVal);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it necessary to put the base data type class? such as int.class.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it necessary to put the base data type class? such as int.class.

Yes, the hashcode is different between Integer.class and int.class

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it necessary to put the base data type class? such as int.class.

Yes, the hashcode is different between Integer.class and int.class

Oh... It is unnecessary... when int auto sealing, intVal.getClass() return Integer. base data type will never be visited
You are right. @Nicole00

@@ -0,0 +1,61 @@
// Copyright 2022-present Weicheng Ye. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the copyright

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the copyright

Sorry, It was my mistake.

@CorvusYe
Copy link
Contributor Author

@Nicole00
I have another question:
Does the current version require java8? Can I use lamda syntax as before?

@Nicole00
Copy link
Contributor

@Nicole00 I have another question: Does the current version require java8? Can I use lamda syntax as before?

Yeah, we require java 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants