-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement:Support more type value as parameter #461
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@wey-gu |
put(Value.class, (Setter<Value>) (param) -> param ); | ||
put(boolean.class, (Setter<Boolean>) Value::bVal); | ||
put(Boolean.class, (Setter<Boolean>) Value::bVal); | ||
put(int.class, (Setter<Integer>) Value::iVal); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it necessary to put the base data type class? such as int.class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it necessary to put the base data type class? such as int.class.
Yes, the hashcode is different between Integer.class
and int.class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it necessary to put the base data type class? such as int.class.
Yes, the hashcode is different between
Integer.class
andint.class
Oh... It is unnecessary... when int auto sealing, intVal.getClass() return Integer. base data type will never be visited
You are right. @Nicole00
@@ -0,0 +1,61 @@ | |||
// Copyright 2022-present Weicheng Ye. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update the copyright
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update the copyright
Sorry, It was my mistake.
@Nicole00 |
Yeah, we require java 8. |
No description provided.