Change transport to header transport #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aiee
force-pushed
the
update-transport
branch
from
15c5d37 to
8a8c640
Compare
Aiee
force-pushed
the
update-transport
branch
from
49b0af2 to
e191cf3
Compare
Codecov ReportBase: 62.64% // Head: 62.64% // No change to project coverage 👍
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #249 +/- ##
=======================================
Coverage 62.64% 62.64%
=======================================
Files 9 9
Lines 2230 2230
=======================================
Hits 1397 1397
Misses 693 693
Partials 140 140
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
HarrisChu
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Address vesoft-inc/nebula#5191
Description:
Still need to test with sf100 dataset
UPDAET:
tested query
"use sf100;lookup on Person yield id(vertex) as vid | limit 500000 | go from $-.vid over LIKES yield distinct LIKES._src as src, LIKES._dst as dst"with sf100 and the errorBigFrames not supported: got size 1112098630was returned.How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Note that here I warp the buffered transport with the header transport, because if use only the header transport,
TestReconnectwill fail.When sending the query to an unavailable server,
BufferedTransportreturnsthrift.END_OF_FILEwhileHeaderTransportreturnsthrift.UNKNOWN_TRANSPORT_EXCEPTION. Not sure if this is expected.