update storage client for plato #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jievince
force-pushed
the
new-scan
branch
6 times, most recently
from
6e749b1 to
f84b47a
Compare
jievince
force-pushed
the
new-scan
branch
2 times, most recently
from
63e7517 to
13a38ba
Compare
jievince
force-pushed
the
new-scan
branch
5 times, most recently
from
7c243aa to
6b203d1
Compare
jievince
force-pushed
the
new-scan
branch
4 times, most recently
from
c0448de to
7a513b7
Compare
jievince
force-pushed
the
new-scan
branch
3 times, most recently
from
9856ab5 to
9135a71
Compare
jievince
force-pushed
the
new-scan
branch
2 times, most recently
from
1821679 to
9503f68
Compare
Correct cursor usage.
Shylock-Hg
reviewed
Dec 6, 2021
Shylock-Hg
reviewed
Dec 6, 2021
src/ClientTest.h
Outdated
| @@ -5,6 +5,9 @@ | |||
|
|
|||
There was a problem hiding this comment.
Don't move this this file.
There was a problem hiding this comment.
Graph/Meta/Storage' client test all need this file, so where should I put this file?
There was a problem hiding this comment.
Write another in storage test folder.
Shylock-Hg
reviewed
Dec 6, 2021
| @@ -4,15 +4,16 @@ | |||
| */ | |||
|
|
|||
| #include "common/datatypes/Geography.h" | |||
| #include "common/geo/io/wkt/WKTWriter.h" | |||
There was a problem hiding this comment.
sorry, I will put it back.
Shylock-Hg
reviewed
Dec 6, 2021
src/thrift/ThriftClientManager-inl.h
Outdated
| VLOG(2) << "Connecting to " << host << " for " << ++connectionCount << " times"; | ||
| std::shared_ptr<folly::AsyncSocket> socket; | ||
| evb->runImmediatelyOrRunInEventBaseThreadAndWait([&socket, evb, resolved]() { | ||
| // if (enableSSL_) { |
Shylock-Hg
reviewed
Dec 6, 2021
include/nebula/sclient/Init.h
Outdated
|
|
||
| namespace nebula { | ||
|
|
||
| void init(int *argc, char **argv[]); |
There was a problem hiding this comment.
Sorry, forget to delete this file.
|
Write a case to test ssl connection for storage/meta client. |
ok |
Shylock-Hg
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The meta client and storage client are designed for Plato only. It's should not be used by ordinary users