-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit. #1
Conversation
readline "github.com/shylock-hg/readline" | ||
) | ||
|
||
const ttyColorPrefix = "\033[" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, you can reference the color package such as gookit/color
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't plan to use third-party package if no necessary.
* | ||
* This source code is licensed under Apache 2.0 License, | ||
* attached with Common Clause Condition 1.0, found in the LICENSES directory. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you need jedib0t/go-pretty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with @darionyaphet
If so, you can avoid these alignment issues
Need a better format for the empty dataset. |
Thanks. Good catch. |
|
|
Try the latest commit, I can't simply reproduce this. |
cli.go
Outdated
"os" | ||
"path" | ||
|
||
readline "github.com/shylock-hg/readline" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If using your repo, how do you consider to upgrade readline library later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is stable. And it's why I don't plan to introduce too many 3rd package which is personal maintained.
Maybe you can use libedit to replace the readline library |
No description provided.