Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit. #1

Merged
merged 26 commits into from
Jul 24, 2020
Merged

Initial commit. #1

merged 26 commits into from
Jul 24, 2020

Conversation

Shylock-Hg
Copy link
Contributor

No description provided.

readline "github.com/shylock-hg/readline"
)

const ttyColorPrefix = "\033["

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, you can reference the color package such as gookit/color

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't plan to use third-party package if no necessary.

*
* This source code is licensed under Apache 2.0 License,
* attached with Common Clause Condition 1.0, found in the LICENSES directory.
*/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you need jedib0t/go-pretty

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with @darionyaphet

If so, you can avoid these alignment issues

@CPWstatic
Copy link
Contributor

(user@Nebula-Console) [(test1)]> get subgraph 1 steps from "1"
=
|
=
Got 0 rows, 0 columns.
time spent 1205/2806 us
2020-06-12 14:17:56

Need a better format for the empty dataset.

@Shylock-Hg
Copy link
Contributor Author

(user@Nebula-Console) [(test1)]> get subgraph 1 steps from "1"
=
|
=
Got 0 rows, 0 columns.
time spent 1205/2806 us
2020-06-12 14:17:56

Need a better format for the empty dataset.

Thanks. Good catch.

@Shylock-Hg Shylock-Hg requested a review from darionyaphet June 12, 2020 08:02
@CPWstatic
Copy link
Contributor

(user@Nebula-Console) [(test)]> go from "1" over like yield $^.person.name as name, like._dst as id, like.likeness as likeness
===========================================
|  name       |  id          |  likeness  |
===========================================
|  "william"  |  "2"  |  99        |
-------------------------------------------

@CPWstatic
Copy link
Contributor

(user@Nebula-Console) [(test)]> get subgraph 1 step from "1"
===========================================
|  _vertices  |  _edges                   |
===========================================
|  [1,]       |  [1-[like]->2@0,]  |
-------------------------------------------

@Shylock-Hg
Copy link
Contributor Author

(user@Nebula-Console) [(test)]> get subgraph 1 step from "1"
===========================================
|  _vertices  |  _edges                   |
===========================================
|  [1,]       |  [1-[like]->2@0,]  |
-------------------------------------------

Try the latest commit, I can't simply reproduce this.

main.go Outdated Show resolved Hide resolved
cli.go Outdated
"os"
"path"

readline "github.com/shylock-hg/readline"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If using your repo, how do you consider to upgrade readline library later?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is stable. And it's why I don't plan to introduce too many 3rd package which is personal maintained.

@yixinglu
Copy link
Contributor

yixinglu commented Jul 20, 2020

Maybe you can use libedit to replace the readline library

@Shylock-Hg Shylock-Hg requested review from CPWstatic and yixinglu July 23, 2020 04:19
@dutor dutor merged commit 84db74a into vesoft-inc:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants