Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add routeId support #61

Merged

Conversation

AnnaKudriasheva
Copy link
Collaborator

Description

  • Added routeId support to the form component. React alternative to the .setRouteId() from the core library.

Motivation and Context

  • Functional gap. It is not possible to specify routeId in the React component.

How Has This Been Tested?

Screenshots (if appropriate):

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@AnnaKudriasheva AnnaKudriasheva requested a review from a team November 7, 2024 01:20
src/Form.tsx Outdated
@@ -58,6 +59,7 @@ function CollectForm(props: ICollectFormProps) {
window.VGSCollect &&
Object.keys(getFormInstance()).length === 0
) {
console.log('HERE!!!', props, routeId);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to remove it :)

@AnnaKudriasheva AnnaKudriasheva merged commit 50ea4b2 into verygoodsecurity:main Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants